Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AlphaPicker #11728
Add AlphaPicker #11728
Changes from all commits
ded69ba
42cc3e5
9c950ff
c7157e5
921a86c
488916b
8a8dbe9
b1fd35d
e6efbc7
ce91990
f0e1636
9d79ef1
927c0a0
e34e33e
c0d1f53
d4f6b65
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an error in the console that only happens when I first open the Picker (and doesn't happen again after) but I'm having a hard time following the stack trace to pinpoint the exact error 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed this as well and in testing. It's from calling focus on a ref and I haven't figure out a way to get by it. Using useEffect causing scroll to top issues and same with autoFocus. Might need your help jamming on this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to debug this a bit locally. When I remove the
textFieldFocus
andsetTextFieldFocus
wherever they're defined/used in Picker, the error never shows and SearchField behavior still remained the same. The issue with that is we lose keyboard nav on the Listbox. But if I made thetextFieldFocused
context on Listbox tied topopoverActive
, keyboard nav works as expected.Since
focused
on SearchField is always set to true, I think this would work but also very happy to have a jam session to dive deeper and verify if there's any ramifications to this. I'm not 100% sure what the scroll to top issues you were having were but testing locally, I can still scroll on the overall DetailsPage regardless of whether Picker is open or not.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work! Thanks Lo!