Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[polaris.shopify.com] Fix broken images #11741

Merged
merged 2 commits into from
Mar 15, 2024
Merged

[polaris.shopify.com] Fix broken images #11741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bb08c2
Remove broken guidance from setting toggle
tjonx Mar 15, 2024
7468d47
Fix modal guidance images
tjonx Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions polaris.shopify.com/content/components/deprecated/setting-toggle.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,22 +65,6 @@ The setting toggle component should only be used when:

If the setting is dependent on other settings, uses progressive disclosure, or has options that are not a simple “On”/“Off”, use a different UI element such as [Checkbox](https://polaris.shopify.com/components/selection-and-input/checkbox) or [Radio button](https://polaris.shopify.com/components/selection-and-input/radio-button).

<DoDont>

#### Do

Only include the actions Turn on/ Turn off.

![Setting toggle do](/images/components/deprecated/setting-toggle/Do.png)

#### Don’t

Don't include additional settings or inputs.

![Setting toggle dont](/images/components/deprecated/setting-toggle/Dont.png)

</DoDont>

---

## Content guidelines
Expand Down
4 changes: 2 additions & 2 deletions polaris.shopify.com/content/components/internal-only/modal.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,13 +206,13 @@ Tertiary actions should:

#### Do

![Screenshot of modal with a plain button as a tertiary action](/images/components/internal-only/modal/[email protected])
![Screenshot of modal with a plain button as a tertiary action](/images/components/deprecated/modal/[email protected])

Use a plain button for a tertiary action if needed

#### Don’t

![Screenshot of modal with a destructive button as a tertiary action](/images/components/internal-only/modal/[email protected])
![Screenshot of modal with a destructive button as a tertiary action](/images/components/deprecated/modal/[email protected])

Use a tertiary action for a destructive action

Expand Down
0 [email protected] → [email protected]
View file
Open in desktop
File renamed without changes
0 [email protected] → [email protected]
View file
Open in desktop
File renamed without changes
Loading