[Icon] Add PersonSegment #11778
Merged
[Icon] Add PersonSegment #11778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-b-rose
approved these changes
Mar 22, 2024
Co-authored-by: Sam Rose <[email protected]>
Co-authored-by: Sam Rose <[email protected]>
Co-authored-by: Sam Rose <[email protected]>
|
I will need a 16x16 variant for https://github.com/Shopify/admin-ui-foundations/tree/main/admin-ui-icons |
Merged
sophschneider
pushed a commit
that referenced
this pull request
Mar 26, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Minor Changes - [#11778](#11778) [`d689bd8f4`](d689bd8) Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Added `PersonSegment` icon ## @shopify/[email protected] ### Minor Changes - [#11764](#11764) [`880f31b44`](880f31b) Thanks [@itwasmattgregg](https://github.com/itwasmattgregg)! - Added align property for FooterHelp - [#11691](#11691) [`1e613de8b`](1e613de) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - - Added `ThemeProvider` component - Removed `html` from theme classes to remove global theme constraint - Updated `useTheme` to be context aware of parent themes - Updated `Portal` component to be context aware of parent themes - Initialized a `dark-experimental` theme - [#11787](#11787) [`c3aefafe2`](c3aefaf) Thanks [@chloerice](https://github.com/chloerice)! - Added support for destructive `promotodBulkActions` to `BulkActions` ### Patch Changes - Updated dependencies \[[`1e613de8b`](1e613de), [`d689bd8f4`](d689bd8)]: - @shopify/[email protected] - @shopify/[email protected] ## @shopify/[email protected] ### Minor Changes - [#11691](#11691) [`1e613de8b`](1e613de) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - - Added `ThemeProvider` component - Removed `html` from theme classes to remove global theme constraint - Updated `useTheme` to be context aware of parent themes - Updated `Portal` component to be context aware of parent themes - Initialized a `dark-experimental` theme ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`1e613de8b`](1e613de)]: - @shopify/[email protected] - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`1e613de8b`](1e613de)]: - @shopify/[email protected] ## [email protected] ### Patch Changes - Updated dependencies \[[`1e613de8b`](1e613de)]: - @shopify/[email protected] ## [email protected] ### Patch Changes - [#11776](#11776) [`ca8eb99ea`](ca8eb99) Thanks [@sarahill](https://github.com/sarahill)! - Updated common action patterns example - Updated dependencies \[[`880f31b44`](880f31b), [`1e613de8b`](1e613de), [`d689bd8f4`](d689bd8), [`c3aefafe2`](c3aefaf)]: - @shopify/[email protected] - @shopify/[email protected] - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Adds `PersonSegment` icon for Customer Segments ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Sam Rose <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Adds
PersonSegmenticon for Customer SegmentsHow to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes