Remove Text heading2xl and associated tokens from v14 font migration
#11813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgriffee
changed the title
heading2xl from v14 font migration
|
/snapit |
|
🫰✨ Thanks @lgriffee! Your snapshot has been published to npm. Test the snapshot by updating your pnpm add --workspace-root @shopify/[email protected]yarn add @shopify/[email protected]npm install @shopify/[email protected] |
lgriffee
changed the title
heading2xl from v14 font migrationText heading2xl and associated tokens from v14 font migration
sam-b-rose
approved these changes
Apr 2, 2024
lgriffee
commented
Apr 2, 2024
Merged
sam-b-rose
pushed a commit
that referenced
this pull request
Apr 4, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Minor Changes - [#11816](#11816) [`4b730c84d`](4b730c8) Thanks [@dGoligorsky](https://github.com/dGoligorsky)! - Added some icons for image editing ### Patch Changes - [#11825](#11825) [`fd5b31d59`](fd5b31d) Thanks [@ryanwilsonperkin](https://github.com/ryanwilsonperkin)! - Add missing peer dependency on React ## @shopify/[email protected] ### Minor Changes - [#11785](#11785) [`2a2f635ba`](2a2f635) Thanks [@mrcthms](https://github.com/mrcthms)! - Added the `defaultPaginatedSelectAllText` prop to `IndexTable` to support customizing the label of the checkbox in the header that selects all rows across pages when the table `hasMoreItems` ### Patch Changes - [#11833](#11833) [`810532c58`](810532c) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Revert responsive text style updates - [#11810](#11810) [`66dc0392a`](66dc039) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed Shift + click selection of `IndexTable.Row` not working in Firefox - [#11811](#11811) [`9aea67322`](9aea673) Thanks [@lgriffee](https://github.com/lgriffee)! - Undeprecated `heading2xl` variant in `Text` component - [#11817](#11817) [`936765c92`](936765c) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - [IndexTable] Initially hide the scrollbar and update scrollbar padding - [#11819](#11819) [`35eb10c4f`](35eb10c) Thanks [@kyledurand](https://github.com/kyledurand)! - Added multi select functionality to AlphaPicker - Updated dependencies \[[`fd5b31d59`](fd5b31d), [`4b730c84d`](4b730c8)]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - [#11813](#11813) [`c49809998`](c498099) Thanks [@lgriffee](https://github.com/lgriffee)! - Removed `Text` `heading2xl` and associated tokens from v14 font migration ## [email protected] ### Patch Changes - [#11796](#11796) [`c8dc01330`](c8dc013) Thanks [@sarahill](https://github.com/sarahill)! - Updated common action pattern guidance - [#11811](#11811) [`9aea67322`](9aea673) Thanks [@lgriffee](https://github.com/lgriffee)! - Undeprecated `heading2xl` variant in `Text` component - Updated dependencies \[[`fd5b31d59`](fd5b31d), [`810532c58`](810532c), [`66dc0392a`](66dc039), [`9aea67322`](9aea673), [`4b730c84d`](4b730c8), [`2a2f635ba`](2a2f635), [`936765c92`](936765c), [`35eb10c4f`](35eb10c)]: - @shopify/[email protected] - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
…ion (Shopify#11813) ### WHY are these changes introduced? Part of https://github.com/Shopify/polaris-internal/issues/1529 ### WHAT is this pull request doing? This PR updates the migration for deprecated `font` custom properties based on the undeprecation of heading2xl. #### v14-styles-replace-custom-property-font | Deprecated CSS Custom Property | Replacement Value | | -- | -- | | ~`--p-font-size-750`~ | ~`--p-font-size-600`~ | | `--p-font-size-800` | ~`--p-font-size-600`~<br>`--p-font-size-750` | | `--p-font-size-900` | ~`--p-font-size-600`~<br>`--p-font-size-750` | | `--p-font-size-1000` | ~`--p-font-size-600`~<br>`--p-font-size-750` | | ~`--p-font-letter-spacing-denser`~ | ~`--p-font-letter-spacing-dense`~ | | `--p-font-letter-spacing-densest` | ~`--p-font-letter-spacing-dense`~<br>`--p-font-letter-spacing-denser` | | ~`--p-font-line-height-1000`~ | ~`--p-font-line-height-800`~ | | `--p-font-line-height-1200` | ~`--p-font-line-height-800`~<br>`--p-font-line-height-1000` | |`--p-text-heading-3xl-font-family`| ~`--p-text-heading-xl-font-family`~<br>`--p-text-heading-2xl-font-family`| |`--p-text-heading-3xl-font-size`| ~`--p-text-heading-xl-font-size`~<br>`--p-text-heading-2xl-font-size`| | `--p-text-heading-3xl-font-weight`| ~`--p-text-heading-xl-font-weight`~<br>`--p-text-heading-2xl-font-weight`| |`--p-text-heading-3xl-font-letter-spacing`| ~`--p-text-heading-xl-font-letter-spacing`~<br>`--p-text-heading-2xl-font-letter-spacing`| | `--p-text-heading-3xl-font-line-height`| ~`--p-text-heading-xl-font-line-height`~<br>`--p-text-heading-2xl-font-line-height`| |~`--p-text-heading-2xl-font-family`~| ~`--p-text-heading-xl-font-family`~| | ~`--p-text-heading-2xl-font-size`~| ~`--p-text-heading-xl-font-size`~| | ~`--p-text-heading-2xl-font-weight`~| ~`--p-text-heading-xl-font-weight`~| | ~`--p-text-heading-2xl-font-letter-spacing`~| ~`--p-text-heading-xl-font-letter-spacing`~| |~`--p-text-heading-2xl-font-line-height`~| ~`--p-text-heading-xl-font-line-height`~| >[!NOTE] >Major version upgrade guidance is updated [on a separate PR on the v13 branch](Shopify#11815).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Part of https://github.com/Shopify/polaris-internal/issues/1529
WHAT is this pull request doing?
This PR updates the migration for deprecated
fontcustom properties based on the undeprecation of heading2xl.v14-styles-replace-custom-property-font
--p-font-size-750--p-font-size-600--p-font-size-800--p-font-size-600--p-font-size-750--p-font-size-900--p-font-size-600--p-font-size-750--p-font-size-1000--p-font-size-600--p-font-size-750--p-font-letter-spacing-denser--p-font-letter-spacing-dense--p-font-letter-spacing-densest--p-font-letter-spacing-dense--p-font-letter-spacing-denser--p-font-line-height-1000--p-font-line-height-800--p-font-line-height-1200--p-font-line-height-800--p-font-line-height-1000--p-text-heading-3xl-font-family--p-text-heading-xl-font-family--p-text-heading-2xl-font-family--p-text-heading-3xl-font-size--p-text-heading-xl-font-size--p-text-heading-2xl-font-size--p-text-heading-3xl-font-weight--p-text-heading-xl-font-weight--p-text-heading-2xl-font-weight--p-text-heading-3xl-font-letter-spacing--p-text-heading-xl-font-letter-spacing--p-text-heading-2xl-font-letter-spacing--p-text-heading-3xl-font-line-height--p-text-heading-xl-font-line-height--p-text-heading-2xl-font-line-height--p-text-heading-2xl-font-family--p-text-heading-xl-font-family--p-text-heading-2xl-font-size--p-text-heading-xl-font-size--p-text-heading-2xl-font-weight--p-text-heading-xl-font-weight--p-text-heading-2xl-font-letter-spacing--p-text-heading-xl-font-letter-spacing--p-text-heading-2xl-font-line-height--p-text-heading-xl-font-line-heightNote
Major version upgrade guidance is updated on a separate PR on the v13 branch.