Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add escapeRegex string utility #11818

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Add escapeRegex string utility #11818

merged 1 commit into from
Apr 2, 2024

Conversation

kyledurand
Copy link
Member

@kyledurand kyledurand commented Apr 2, 2024

WHY are these changes introduced?

The picker was exploding when special characters were getting typed into the search field.

WHAT is this pull request doing?

Adds a string util to escape special characters. Internal use only so skipping changeset

How to 🎩

Open the Picker and enter open bracket, square bracket, parenthesis etc.. in the search field: Storybook

@kyledurand kyledurand added 🤖Skip Changelog Causes CI to ignore changelog update check. #gsd:38419 Pickers labels Apr 2, 2024
@kyledurand kyledurand self-assigned this Apr 2, 2024
@kyledurand kyledurand requested a review from laurkim April 2, 2024 14:53
@kyledurand kyledurand merged commit 8ffddd6 into main Apr 2, 2024
19 of 20 checks passed
@kyledurand kyledurand deleted the add-escape-regex-util branch April 2, 2024 16:42
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
### WHY are these changes introduced?

The picker was exploding when special characters were getting typed into
the search field.

### WHAT is this pull request doing?

Adds a string util to escape special characters. Internal use only so
skipping changeset

### How to 🎩

Open the Picker and enter open bracket, square bracket, parenthesis
etc.. in the search field:
[Storybook](https://5d559397bae39100201eedc1-qccucmxydk.chromatic.com/?path=/story/playground--details-page)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:38419 Pickers 🤖Skip Changelog Causes CI to ignore changelog update check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants