Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing svgo dev dependency #11824

Merged
merged 6 commits into from
Apr 9, 2024
Merged

Add missing svgo dev dependency #11824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e18817c
Fix lint formatting
ryanwilsonperkin Apr 2, 2024
78872b4
Revert polaris-for-vscode formatting updates
aaronccasanova Apr 8, 2024
bcbbcdb
Re-add svgo devDependency removed in #11328
aaronccasanova Apr 8, 2024
6881a50
Revert polaris-tokens formatting updates
aaronccasanova Apr 8, 2024
b364655
Revert polaris-react formatting updates
aaronccasanova Apr 8, 2024
ce983d8
Update changeset entries
aaronccasanova Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/neat-bulldogs-love.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris-icons': patch
---

Added missing `svgo` dev dependency
5 changes: 5 additions & 0 deletions .changeset/silver-rocks-own.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Lint fixes
1 change: 1 addition & 0 deletions polaris-icons/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
"hast-util-select": "^3.0.0",
"js-yaml": "^4.0.0",
"rehype-parse": "^7.0.1",
"svgo": "^2.8.0",
"unified": "^9.2.1"
},
"peerDependencies": {
Expand Down
1 change: 0 additions & 1 deletion polaris-icons/tests/validate-svg-content.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
const fs = require('fs');
const path = require('path');

// eslint-disable-next-line import/no-extraneous-dependencies
const svgo = require('svgo');
const globby = require('globby');
const unified = require('unified');
Expand Down
2 changes: 1 addition & 1 deletion polaris-react/postcss-mixins/no-focus-ring.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
&::after {
content: none;
}
} ;
}
2 changes: 1 addition & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20775,7 +20775,7 @@ svg-tags@^1.0.0:
resolved "https://registry.yarnpkg.com/svg-tags/-/svg-tags-1.0.0.tgz#58f71cee3bd519b59d4b2a843b6c7de64ac04764"
integrity sha1-WPcc7jvVGbWdSyqEO2x95krAR2Q=

svgo@^2.7.0:
svgo@^2.7.0, svgo@^2.8.0:
version "2.8.0"
resolved "https://registry.yarnpkg.com/svgo/-/svgo-2.8.0.tgz#4ff80cce6710dc2795f0c7c74101e6764cfccd24"
integrity sha512-+N/Q9kV1+F+UeWYoSiULYo4xYSDQlTgb+ayMobAXPwMnLvop7oxKMo9OzIrX5x3eS4L4f2UHhc9axXwY8DpChg==
Expand Down
Loading