Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Jest 29 #11924

Merged
merged 1 commit into from
Apr 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/brown-dodos-knock.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
'@shopify/polaris-icons': patch
'@shopify/polaris-migrator': patch
'@shopify/polaris': patch
'@shopify/polaris-tokens': patch
'polaris.shopify.com': patch
---

Upgrade to jest 29
7 changes: 4 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,15 @@
"@shopify/stylelint-plugin": "^11.0.0",
"@shopify/typescript-configs": "^5.1.0",
"@size-limit/preset-small-lib": "^5.0.3",
"@types/jest": "^27.5.1",
"@types/jest": "^29.5.12",
"@types/node": "^20.10.0",
"babel-loader": "^9.1.2",
"eslint": "^8.3.0",
"execa": "^5.0.0",
"jest": "^27.5.1",
"jest": "^29.7.0",
"jest-environment-jsdom": "^29.7.0",
"jest-preset-stylelint": "^5.0.3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a newer version of this (7.0.0), but it started throwing the following error:

TypeError: A dynamic import callback was invoked without --experimental-vm-modules
       at loadLint (../node_modules/.pnpm/[email protected][email protected]/node_modules/jest-preset-stylelint/getTestRule.js:16:31)

Our current version is fully compatible with jest 29, so I'll just leave that upgrade for a different PR.

"jest-watch-typeahead": "^1.0.0",
"jest-watch-typeahead": "^2.2.2",
"js-yaml": "^4.1.0",
"npm-run-all": "^4.1.5",
"postinstall-postinstall": "^2.1.0",
Expand Down
Loading
Loading