Add Shopify Finance icons #12233
Add Shopify Finance icons #12233
Conversation
ngkay
requested review from
alex-page,
sam-b-rose and
gwyneplaine
as code owners
ngkay
force-pushed
the
kn/finance-icons
branch
2 times, most recently
from
b6d0301
to
11e55a8
Compare
|
Hey @ngkay what is the urgency behind this icon addition. |
hey @alex-page, product and UX find this an important part of the the Finances Unification so we want to have this for them ASAP |
ngkay
force-pushed
the
kn/finance-icons
branch
6 times, most recently
from
7bb9c1a
to
49c1db1
Compare
|
@ngkay totally understand. Just wanted to know if it was needed for Editions? If not we will add this icon post editions. |
@alex-page would after Editions be the first week of July or later? |
|
It would be in July. I can't give accurate weekly estimates. |
|
@heyjoethomas @ngkay @alex-page let's use the receipt icon for purchases and refunds ✅ 
|
@mujicaed it looks like the actual Receipt icon is slightly different |
|
@heyjoethomas the ReceiptIcon looks to be misaligned across Figma and code. Should we update it as a part of this work? |
Yeah. I can help make sure that happens. |
|
Figma has been updated to reflect what is in this repository. |
|
@heyjoethomas thank you! I was wondering if we should use the old design in Figma here. Sounds like you made a call to just align them. That is all good but just saying we can update it here too if you wanted that design. |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Minor Changes - [#12233](#12233) [`491cf8038`](491cf80) Thanks [@ngkay](https://github.com/ngkay)! - Adds new icons for Shopify Finance ## @shopify/[email protected] ### Minor Changes - [#12359](#12359) [`8f0f1b7e0`](8f0f1b7) Thanks [@mrcthms](https://github.com/mrcthms)! - Removed all references to the dynamicTopBarAndReframe feature and revert functionality back to how it was ### Patch Changes - Updated dependencies \[[`491cf8038`](491cf80)]: - @shopify/[email protected] ## [email protected] ### Patch Changes - Updated dependencies \[[`8f0f1b7e0`](8f0f1b7), [`491cf8038`](491cf80)]: - @shopify/[email protected] - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
@alex-page That is because we have a bunch of variants of the |
WHY are these changes introduced?
Fixes #12171
WHAT is this pull request doing?
Adds new icons for Shopify Finance
Figma - the icons marked "Ready for dev"
Project
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes