-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move reference to unreleased v14 to the v14.0.0 branch #12400
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically as soon as a migration is added to our repo we provide accompanying guidance even when it's a migration for the next major version. If the issue here is the link then I would suggest that we only remove that one sentence with the link and add it to the v14 branch in the same location. I think only that should be updated not the removal of this migration content.
@@ -37,35 +37,6 @@ npx @shopify/polaris-migrator <migration> <path> | |||
|
|||
## Migrations | |||
|
|||
### @shopify/polaris-react v14.0.0 | |||
|
|||
If you are upgrading Polaris from v13 to v14 please follow our [migration guide](/version-guides/migrating-from-v13-to-v14). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only line I'd remove here is line 42 and then make sure to add it to the v14 branch after this merges.
66a4fe0
to
b698288
Compare
A good argument well made! I've restored the v14 steps, only removing the link to the non-existent migration guide 👍 |
It's already in the
v14.0.0
branch, not sure how it made its way intomain
.