Move reference to unreleased v14 to the v14.0.0 branch #12400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesstelford
added
the
🤖Skip Changelog
lgriffee
requested changes
Jul 16, 2024
There was a problem hiding this comment.
Typically as soon as a migration is added to our repo we provide accompanying guidance even when it's a migration for the next major version. If the issue here is the link then I would suggest that we only remove that one sentence with the link and add it to the v14 branch in the same location. I think only that should be updated not the removal of this migration content.
| @@ -37,35 +37,6 @@ npx @shopify/polaris-migrator <migration> <path> | |||
|
|
|||
| ## Migrations | |||
|
|
|||
| ### @shopify/polaris-react v14.0.0 | |||
|
|
|||
| If you are upgrading Polaris from v13 to v14 please follow our [migration guide](/version-guides/migrating-from-v13-to-v14). | |||
There was a problem hiding this comment.
The only line I'd remove here is line 42 and then make sure to add it to the v14 branch after this merges.
jesstelford
force-pushed
the
remove-reference-to-v14
branch
from
66a4fe0
to
b698288
Compare
|
A good argument well made! I've restored the v14 steps, only removing the link to the non-existent migration guide 👍 |
lgriffee
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's already in the
v14.0.0branch, not sure how it made its way intomain.