Clean up experimental dark tokens #12467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
sophschneider
force-pushed
the
sophie/topbar-token-clean-up
branch
2 times, most recently
from
8849ffd
to
4c6f71a
Compare
sophschneider
force-pushed
the
sophie/topbar-token-clean-up
branch
from
4c6f71a
to
4cd5942
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
/snapit |
|
🫰✨ Thanks @sophschneider! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/polaris-icons": "0.0.0-snapshot-20240729151723",
"@shopify/polaris-migrator": "0.0.0-snapshot-20240729151723",
"@shopify/polaris": "0.0.0-snapshot-20240729151723",
"@shopify/polaris-tokens": "0.0.0-snapshot-20240729151723",
"@shopify/stylelint-polaris": "0.0.0-snapshot-20240729151723" |
sophschneider
requested review from
alex-page,
sam-b-rose and
gwyneplaine
as code owners
sophschneider
commented
Jul 29, 2024
| 'color-bg-surface-secondary-active': {value: colors.whiteAlpha[9]}, | ||
| 'color-bg-surface-secondary-hover': {value: colors.whiteAlpha[6]}, | ||
| 'color-bg-fill-transparent': {value: colors.whiteAlpha[8]}, | ||
| 'color-bg-fill-brand': {value: colors.gray[1]}, | ||
| 'color-text-brand-on-bg-fill': {value: colors.gray[15]}, | ||
| 'color-bg-surface-hover': {value: colors.gray[14]}, | ||
| 'color-bg-fill-hover': {value: 'rgba(37, 37, 37, 1)'}, | ||
| 'color-bg-fill-hover': {value: colors.whiteAlpha[5]}, |
There was a problem hiding this comment.
@bernardojoaogarcia would you be able to double check these values? I think I cross referenced all of them but want a second pair of eyes
sophschneider
changed the title
|
Make sure this doesn't break the file editor 🙏 |
|
@alex-page fo sho! I already tophatted with the file editor next beta but might be worth @dustinmalik taking a look to double check 
https://admin.web.web-zj1n.sophie-schneider.us.spin.dev/store/shop1/products/1 |
laurkim
approved these changes
Jul 30, 2024
sam-b-rose
approved these changes
Jul 30, 2024
mateus
approved these changes
Jul 30, 2024
mrcthms
approved these changes
Jul 30, 2024
Merged
sophschneider
pushed a commit
that referenced
this pull request
Jul 30, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Minor Changes - [#12467](#12467) [`a98276358`](a982763) Thanks [@sophschneider](https://github.com/sophschneider)! - Remove experimental suffix from tooltip tokens, remove border gradient experimental tokens, add token for `bg-fill-secondary-selected`, and add more `dark-experimental` theme values. ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`a98276358`](a982763)]: - @shopify/[email protected] - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - [#12467](#12467) [`a98276358`](a982763) Thanks [@sophschneider](https://github.com/sophschneider)! - Remove experimental suffix from tooltip tokens, remove border gradient experimental tokens, add token for `bg-fill-secondary-selected`, and add more `dark-experimental` theme values. - Updated dependencies \[[`a98276358`](a982763)]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`a98276358`](a982763)]: - @shopify/[email protected] ## [email protected] ### Patch Changes - Updated dependencies \[[`a98276358`](a982763)]: - @shopify/[email protected] ## [email protected] ### Patch Changes - Updated dependencies \[[`a98276358`](a982763)]: - @shopify/[email protected] - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Part of https://github.com/Shopify/polaris-internal/issues/166
Part of https://github.com/Shopify/polaris-internal/issues/537
WHAT is this pull request doing?
experimentalsuffix from tooltip tokensbg-fill-secondary-selectedtokendark-experimentaltheme changesHow to 🎩
Demo of all button states
Screen.Recording.2024-07-29.at.5.25.10.PM.mov
Figma files with button states
Go through the flow, noticing all button states of:
https://admin.web.web-zj1n.sophie-schneider.us.spin.dev/store/shop1/products/1