Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tag] Add secondary styling #12475

Closed
wants to merge 2 commits into from
Closed

[Tag] Add secondary styling #12475

wants to merge 2 commits into from

Conversation

IlanaB
Copy link

@IlanaB IlanaB commented Jul 29, 2024

This PR introduces a secondary variant of the Tag component. I'm looking for feedback and feasibility in merging this in advance of the Admin UI Foundations project

WHY are these changes introduced?

We're run into an issue where we have a component that contains both badges and tags and we'd like those to visually match. There's currently no way to achieve this without CSS overrides. Since we expect a secondary treatment to be coming I'm using this PR to test the waters in introducing this treatment now.

Screenshot 2024-07-29 at 3 41 09 PM

WHAT is this pull request doing?

This adds a "secondary" variation of the Tag that is compatible with all other variants and lightens the background to use bg-secondary as shown:

Screenshot 2024-07-29 at 3 46 30 PM

Note that on a secondary background the Tag background color will blend in

Currently includes:

  • added new variant and matching styling
  • added to storybook
  • added to polaris docs

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

@IlanaB
Copy link
Author

IlanaB commented Jul 29, 2024

@m-meurer @derekloshopify FYI!

@IlanaB IlanaB closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant