Rename shadow-bevel opt out class name
#9767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronccasanova
requested review from
kyledurand,
sam-b-rose,
chloerice and
sophschneider
aaronccasanova
added
the
🤖Skip Changelog
kyledurand
approved these changes
Jul 19, 2023
sophschneider
approved these changes
Jul 19, 2023
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the
shadow-bevelopt out class name to prevent the override styles from being enabled when the se23 beta-flag is active. There are existing selectors (html[class*="Polaris-Summer-Editions-2023"]) used throughout the organization that partially match theshadow-bevelopt out class, causing both theshadow-bevelandborderstyles to be applied at the same time. @sophschneider and I decided that renaming the class name within Polaris would be quicker and safer than updating existing beta-flag selectors across the organization.