[Pagination] Prefer tooltip position below the buttons #9889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloerice
force-pushed
the
pagination-tooltip-position
branch
from
e5496f7
to
db57f3f
Compare
|
/snapit |
|
🫰✨ Thanks @chloerice! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected] |
laurkim
approved these changes
Aug 7, 2023
|
Trying out the snapshot now, thanks! |
sam-b-rose
pushed a commit
that referenced
this pull request
Aug 15, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Major Changes - [#9887](#9887) [`a3da87e2e`](a3da87e) Thanks [@lgriffee](https://github.com/lgriffee)! - Removed deprecated v10 custom properties from stylelint-polaris disallowed lists ### Patch Changes - Updated dependencies \[[`36e4ee8af`](36e4ee8)]: - @shopify/[email protected] ## @shopify/[email protected] ### Minor Changes - [#10042](#10042) [`1d82a3b12`](1d82a3b) Thanks [@m4thieulavoie](https://github.com/m4thieulavoie)! - introduce a subdued prop to the popover pane component - [#9868](#9868) [`cb1dbbbd3`](cb1dbbb) Thanks [@mattkubej](https://github.com/mattkubej)! - Introduce disableKeyboardShortcuts prop to IndexFilters - [#9862](#9862) [`93b902094`](93b9020) Thanks [@brittcorry](https://github.com/brittcorry)! - Added support for the ```Filters``closeOnChildOverlayClick``` prop to `IndexFilters` - [#9872](#9872) [`f585a57e0`](f585a57) Thanks [@fatimasajadi](https://github.com/fatimasajadi)! - Add a critical status to the IndexTable ### Patch Changes - [#10012](#10012) [`3ae94cef0`](3ae94ce) Thanks [@melvinadu](https://github.com/melvinadu)! - Fixed wrapping overflow of strings with no spacing within `Filters` popover - [#9889](#9889) [`0cbdbb4f5`](0cbdbb4) Thanks [@chloerice](https://github.com/chloerice)! - Set the preferred position of `Pagination` and `Page` `secondaryActions` button tooltips to `below` - [#10045](#10045) [`65ad4e27c`](65ad4e2) Thanks [@sophschneider](https://github.com/sophschneider)! - Fixed BannerExperimental no title hidden icon variant - [#9885](#9885) [`f0d288099`](f0d2880) Thanks [@bsharrow](https://github.com/bsharrow)! - `Aligned the`SkeletonPage\``title`font-weight with the`Page` title - [#9860](#9860) [`af0c9d4a2`](af0c9d4) Thanks [@sophschneider](https://github.com/sophschneider)! - Updated CI tests to account for both polarisSummerEditions2023 beta flag states - [#9874](#9874) [`5569ac69a`](5569ac6) Thanks [@chloerice](https://github.com/chloerice)! - Fixed `Page` first `Header` row misalignment - [#9850](#9850) [`57d8d5506`](57d8d55) Thanks [@kyledurand](https://github.com/kyledurand)! - Rebuilt `Filters` `SearchField` - [#8988](#8988) [`535b3fc91`](535b3fc) Thanks [@m4thieulavoie](https://github.com/m4thieulavoie)! - Added support for rendering `Text` `as` a `strong` tag - [#9912](#9912) [`00b831292`](00b8312) Thanks [@samrose3](https://github.com/samrose3)! - Fixed primary Button styles for Chrome on Android devices - Updated dependencies \[[`d1bee0f87`](d1bee0f), [`36e4ee8af`](36e4ee8)]: - @shopify/[email protected] - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`a3da87e2e`](a3da87e), [`36e4ee8af`](36e4ee8)]: - @shopify/[email protected] - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - [#9879](#9879) [`d1bee0f87`](d1bee0f) Thanks [@kyledurand](https://github.com/kyledurand)! - Optimized some unoptimized icons ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`a3da87e2e`](a3da87e), [`36e4ee8af`](36e4ee8)]: - @shopify/[email protected] - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - [#9904](#9904) [`36e4ee8af`](36e4ee8) Thanks [@benwolfram](https://github.com/benwolfram)! - Added a unit to the `space-0` token ## [email protected] ### Minor Changes - [#9886](#9886) [`d85099c89`](d85099c) Thanks [@lgriffee](https://github.com/lgriffee)! - Updated Polaris Stylelint version matchups chart ### Patch Changes - Updated dependencies \[[`d1bee0f87`](d1bee0f), [`1d82a3b12`](1d82a3b), [`36e4ee8af`](36e4ee8), [`cb1dbbbd3`](cb1dbbb), [`3ae94cef0`](3ae94ce), [`0cbdbb4f5`](0cbdbb4), [`93b902094`](93b9020), [`65ad4e27c`](65ad4e2), [`f0d288099`](f0d2880), [`af0c9d4a2`](af0c9d4), [`5569ac69a`](5569ac6), [`f585a57e0`](f585a57), [`57d8d5506`](57d8d55), [`535b3fc91`](535b3fc), [`00b831292`](00b8312)]: - @shopify/[email protected] - @shopify/[email protected] - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? When tooltips are provided to the the Page secondary or pagination actions, they default to rendering above the buttons because there's no preferred position set. This is a problem in embedded apps because the AppBridge TitleBar renders over the top of them. <img width="965" alt="Screenshot 2023-08-04 at 1 54 38 PM" src="https://github.com/Shopify/polaris/assets/18447883/0b3f7da1-fbd4-465e-b0e8-5a1d9af2a18f"> ### WHAT is this pull request doing? This PR sets the preferred position of tooltipable actions in `Page` and `Pagination` to "below". ### How to 🎩 🌀 [Spinstance](https://admin.web.page-action-tooltip-alignment.chloe-rice.us.spin.dev/store/shop1/articles/2) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
When tooltips are provided to the the Page secondary or pagination actions, they default to rendering above the buttons because there's no preferred position set. This is a problem in embedded apps because the AppBridge TitleBar renders over the top of them.
WHAT is this pull request doing?
This PR sets the preferred position of tooltipable actions in
PageandPaginationto "below".How to 🎩
🌀 Spinstance
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes