Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IndexTable] Update hover styles for status and subdued rows #9893

Merged
merged 3 commits into from
Aug 10, 2023
Merged

[IndexTable] Update hover styles for status and subdued rows #9893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65c0c1a
[IndexTable] Update hover styles for status rows
laurkim Aug 7, 2023
c9ffc33
[IndexTable] Add story for table with subdued rows
laurkim Aug 9, 2023
c463857
[IndexTable] Update hover styles for subdued rows
laurkim Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions polaris-react/src/components/IndexTable/IndexTable.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,40 @@ $loading-panel-height: 53px;
// other way around.
background-color: var(--p-color-bg-hover);
}

// stylelint-disable selector-max-class, max-nesting-depth, selector-max-combinators, selector-max-compound-selectors -- se23 status hover styles
&.statusCritical {
&,
.TableCell-first,
.TableCell-first + .TableCell {
background-color: var(--p-color-bg-critical-subdued-hover);
}
}

&.statusSubdued {
&,
.TableCell-first,
.TableCell-first + .TableCell {
background-color: var(--p-color-bg-subdued-hover);
}
}

&.statusSuccess {
&,
.TableCell-first,
.TableCell-first + .TableCell {
background-color: var(--p-color-bg-success-subdued-hover);
}
}

&.TableRow-subdued {
&,
.TableCell-first,
.TableCell-first + .TableCell {
background-color: var(--p-color-bg-subdued-hover);
}
}
// stylelint-enable selector-max-class, max-nesting-depth, selector-max-combinators, selector-max-compound-selectors -- se23 status hover styles
}
}

Expand Down
94 changes: 94 additions & 0 deletions polaris-react/src/components/IndexTable/IndexTable.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,6 +657,100 @@ export function WithDisabledRows() {
);
}

export function WithSubduedRows() {
const customers = [
{
id: '3410',
url: '#',
name: 'Mae Jemison',
location: 'Decatur, USA',
orders: 20,
amountSpent: '$2,400',
},
{
id: '3412',
url: '#',
name: 'Sam Jemison',
location: 'Decatur, USA',
orders: 20,
amountSpent: '$400',
},
{
id: '2563',
url: '#',
name: 'Ellen Ochoa',
location: 'Los Angeles, USA',
orders: 30,
amountSpent: '$140',
},
];
const resourceName = {
singular: 'customer',
plural: 'customers',
};

const {selectedResources, allResourcesSelected, handleSelectionChange} =
useIndexResourceState(customers);

const rowMarkup = customers.map(
({id, name, location, orders, amountSpent}, index) => (
<IndexTable.Row
id={id}
key={id}
selected={selectedResources.includes(id)}
position={index}
subdued={index === 1 || index === 2}
>
<IndexTable.Cell>
<Text fontWeight="bold" as="span">
{name}
</Text>
</IndexTable.Cell>
<IndexTable.Cell>{location}</IndexTable.Cell>
<IndexTable.Cell>
<Text as="span" alignment="end" numeric>
{orders}
</Text>
</IndexTable.Cell>
<IndexTable.Cell>
<Text as="span" alignment="end" numeric>
{amountSpent}
</Text>
</IndexTable.Cell>
</IndexTable.Row>
),
);

return (
<LegacyCard>
<IndexTable
resourceName={resourceName}
itemCount={customers.length}
selectedItemsCount={
allResourcesSelected ? 'All' : selectedResources.length
}
onSelectionChange={handleSelectionChange}
headings={[
{title: 'Name'},
{title: 'Location'},
{
alignment: 'end',
id: 'order-count',
title: 'Order count',
},
{
alignment: 'end',
id: 'amount-spent',
title: 'Amount spent',
},
]}
>
{rowMarkup}
</IndexTable>
</LegacyCard>
);
}

export function WithEmptyState() {
const customers = [];
const resourceName = {
Expand Down