adds support for macOS catalyst #3296
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The header files use paths like 'include/core/SkRefCnt.h' but they're actually located at 'cpp/skia/include/core/SkRefCnt.h'. This adds the cpp/skia/ directory to the header search paths so the includes resolve correctly.
This reverts commit ec71440.
wcandillon
reviewed
Aug 21, 2025
wcandillon
requested changes
Aug 21, 2025
Uh probably isn't needed. i can confirm it DOES work though. I built a custom tarbal from this and my app now runs on Catalyst :) |
|
this we remove these extra flags and it works, I would be happy to merge it :) |
|
@itsthisjustin let me know if you have appetite to update this PR so we can test it/merge it. |
|
Sure I can pull the latest and update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds changes from @samuelscheit to the latest main