DSL: passing output data between steps #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dersam
changed the base branch from
10-03-set_up_cog_executor_with_dsl
to
graphite-base/418
dersam
force-pushed
the
10-03-dsl_passing_output_data_between_steps
branch
from
0a61e05 to
11a9669
Compare
dersam
changed the base branch from
graphite-base/418
to
10-04-set_up_typechecking_for_dsl_blocks
dersam
force-pushed
the
10-03-dsl_passing_output_data_between_steps
branch
from
11a9669 to
c7669a4
Compare
dersam
force-pushed
the
10-04-set_up_typechecking_for_dsl_blocks
branch
from
c3a6f64 to
ddbeaf3
Compare
dersam
force-pushed
the
10-03-dsl_passing_output_data_between_steps
branch
from
c7669a4 to
4446c22
Compare
dersam
force-pushed
the
10-04-set_up_typechecking_for_dsl_blocks
branch
2 times, most recently
from
6e28202 to
9449467
Compare
dersam
force-pushed
the
10-03-dsl_passing_output_data_between_steps
branch
from
4446c22 to
59c5cf7
Compare
dersam
changed the base branch from
10-04-set_up_typechecking_for_dsl_blocks
to
graphite-base/418
dersam
force-pushed
the
graphite-base/418
branch
from
9449467 to
e7c33fe
Compare
dersam
force-pushed
the
10-03-dsl_passing_output_data_between_steps
branch
from
59c5cf7 to
6fbcf85
Compare
dersam
force-pushed
the
10-03-dsl_passing_output_data_between_steps
branch
from
6fbcf85 to
991368a
Compare
dersam
changed the base branch from
graphite-base/418
to
10-08-automatically_use_namespaced_config_class_if_present
dersam
force-pushed
the
10-03-dsl_passing_output_data_between_steps
branch
from
991368a to
835c58e
Compare
dersam
force-pushed
the
10-03-dsl_passing_output_data_between_steps
branch
from
835c58e to
9969561
Compare
dersam
changed the base branch from
10-08-automatically_use_namespaced_config_class_if_present
to
graphite-base/418
juniper-shopify
approved these changes
Oct 9, 2025
| cmd(:ls) { "ls -al" } | ||
| cmd(:echo) do | ||
| # TODO: this is a bespoke output object for cmd, is there a generic one we can offer | ||
| first_line = cmd(:ls).command_output.split("\n").second |
| end | ||
|
|
||
| attr_reader :output | ||
| attr_reader :name, :output |
| module Roast | ||
| module DSL | ||
| # Contains the cogs already executed in this run. | ||
| class CogExecutionContext |
There was a problem hiding this comment.
I think this should be called something like CogInputContext, because the proc running in this context is just generating the input for the cog's actual work, which will be done by the cog itself not in a user's proc at all
There was a problem hiding this comment.
I'll drop a rename PR on top of this
juniper-shopify
force-pushed
the
10-03-dsl_passing_output_data_between_steps
branch
from
9969561 to
342cb79
Compare
juniper-shopify
force-pushed
the
graphite-base/418
branch
from
91fe471 to
4571b58
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More context rebinding shenanigans. Inside of a cog level execution block,
cmd(:ls)returns the output object from executing that cog.If the cog has not yet run, it will error, preventing access of cog output before you could possibly have it.
Added a
CogExecutionContextto provide the execution environment for this purpose, and renamed the previousExecutionContexttoWorkflowExecutionContextto reflect its higher level purpose.