Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace print with logging #679

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

outring
Copy link

@outring outring commented Aug 18, 2023

WHY are these changes introduced?

Fixes #678

Replacing raw print to stdout with logging to allow consuming applications decide how they want this data to be presented

WHAT is this pull request doing?

Replaced print with logging.Logger.exception. By default logging in Python prints all events with severity >= WARNING to the stdout/stderr so the existing behavior is maintained in general

Checklist

  • I have updated the CHANGELOG (if applicable)
  • I have followed the Shopify Python guide

@outring
Copy link
Author

outring commented Aug 18, 2023

Just signed the CLA but can't rerun the check myself, sorry. JFYI there are no mentions of CLA in any of the contribution guides around:

Probably worth adding there. I can do that in this PR if it's okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-CLI parts of the library must not write anything to stdout/stderr
1 participant