This repository was archived by the owner on Aug 14, 2023. It is now read-only.
Migrate to @shopify/theme-product-form#142
Merged
chrisberthe merged 4 commits intomasterfrom Feb 20, 2019
Merged
Conversation
4 tasks
t-kelly
changed the title
wizardlyhel
reviewed
Jan 16, 2019
wizardlyhel
reviewed
Jan 16, 2019
t-kelly
requested review from
chrisberthe,
harshal317,
martinamarien and
tauthomas01
chrisberthe
suggested changes
Jan 22, 2019
Contributor
chrisberthe
left a comment
chrisberthe
left a comment
There was a problem hiding this comment.
Loving the extraction of this library! Noticing a couple hiccups but all-in-all, looking great :)
Contributor
|
This is not related to this PR, but the product's pricing isn't transferring properly to the cart, which you can see in this video. In this one, the price is added incorrectly, and when I add the same product again, the pricing changes again. |
chrisberthe
reviewed
Jan 24, 2019
martinamarien
suggested changes
Jan 24, 2019
tauthomas01
reviewed
Feb 4, 2019
Contributor
tauthomas01
left a comment
tauthomas01
left a comment
There was a problem hiding this comment.
Is it possible to regenerate a new demo url? I wasn't able to run in my machine despite doing yarn link.
chrisberthe
approved these changes
Feb 8, 2019
Contributor
chrisberthe
left a comment
chrisberthe
left a comment
There was a problem hiding this comment.
Changes look good on my side - just need to fix the conflict with yarn.lock.
martinamarien
approved these changes
Feb 11, 2019
t-kelly
force-pushed
the
product-form-js
branch
from
a5130fe to
a57ba9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accompanying Shopify/theme-scripts#70
Fixes #140
Demo Shop
Simplifies product form implementation by using the new @shopify/theme-product-form package.
Related: #127