This repository was archived by the owner on Oct 20, 2023. It is now read-only.
API changes #106
Merged
API changes #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinegrant
requested review from
carolineschnapp,
rickitan and
BrendaSegalShopify
|
I need to update the README with the API changes. Do we have new docs (current docs) that reflect these changes? |
|
Ok the REAME has been updated. All good for a round of reviews. |
|
Comments addressed! 👍 |
carolineschnapp
approved these changes
Oct 10, 2019
BrendaSegalShopify
approved these changes
Oct 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I brought the API changes that @rickitan made in #96