This repository was archived by the owner on Oct 20, 2023. It is now read-only.
Adds a note about peer dependency on @shopify/theme-product #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wizardlyhel
approved these changes
Apr 29, 2019
Editor on save formatting, I'll revert that. |
antoinegrant
force-pushed
the
theme-product-form-doc-peer-dep
branch
from
d338dec to
349859d
Compare
huguestennier
approved these changes
May 6, 2019
antoinegrant
force-pushed
the
theme-product-form-doc-peer-dep
branch
from
349859d to
d89795d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base on the discussion, I've added a note to specify that the
@shopify/theme-productneeds to be included before@shopify/theme-product-form.We could go the other route and bundle the dependencies if we'd prefer.