added code actions for disabling theme-check rules #1057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoplando
changed the title
shoplando
force-pushed
the
Add-code-action-to-disable-checks
branch
6 times, most recently
from
eda6b09 to
142ef1c
Compare
aswamy
reviewed
Oct 1, 2025
packages/theme-language-server-common/src/codeActions/providers/DisableCheckProvider.ts
Outdated
Show resolved
Hide resolved
| case 'next-line': { | ||
| let existingCommentLine = -1; | ||
|
|
||
| for (let i = lineNumber - 1; i >= Math.max(0, lineNumber - 5); i--) { |
There was a problem hiding this comment.
what's with these numbers? Why are we deducting -5 from lineNumber?
There was a problem hiding this comment.
Initially, I thought of only looking at maximum 5 lines above the current line because I didn't think people would write more than 5 lines of whitespace, but I now that I think of it, devs should do anything they want.
(same on line 88)
packages/theme-language-server-common/src/commands/providers/ApplyDisableCheckProvider.ts
Show resolved
Hide resolved
| const { textDocument } = document; | ||
|
|
||
| const isInLiquidTag = this.isInLiquidTagContext( | ||
| document as AugmentedLiquidSourceCode, |
There was a problem hiding this comment.
Suggested change
| document as AugmentedLiquidSourceCode, | |
| document, |
There was a problem hiding this comment.
See previous comment
shoplando
force-pushed
the
Add-code-action-to-disable-checks
branch
2 times, most recently
from
28600e9 to
574b199
Compare
shoplando
force-pushed
the
Add-code-action-to-disable-checks
branch
from
574b199 to
b0e517b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Solves #432
Added a new code action provider that allows users to disable Theme Check rules in the quick fix menu. This feature adds two types of actions:
{% # theme-check-disable-next-line CheckName %}comment above the line with the offense{% # theme-check-disable CheckName %}comment at the top of the fileWhat's next? Any followup issues?
What did you learn?
Working with code actions requires careful handling of cursor position and document ranges. It's important to filter duplicate actions when multiple offenses of the same type exist on the same line to avoid cluttering the quick fix menu.
Before you deploy
changeset