Skip to content

Added hover support for inline snippets on render tags #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: render-autocomplete-inline-snippet
Choose a base branch
from
Open

Added hover support for inline snippets on render tags #1073

wants to merge 3 commits into from
+421 −35

Conversation

@shoplando
Copy link
Contributor

@shoplando shoplando commented Oct 14, 2025 •
edited
Loading

What are you adding in this PR?

Solves #829
Added hover support for render handle and named arguments for inline snippets.

What's next? Any followup issues?

  • [ x ] I included a minor bump changeset
  • [ x ] My feature is backward compatible

This was referenced Oct 14, 2025
Open
Open
Open
@shoplando Graphite App
Copy link
Contributor Author

shoplando commented Oct 14, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shoplando shoplando changed the title introduced snippet tag in ohm Added hover support for inline snippets on render tags Oct 14, 2025
@shoplando shoplando force-pushed the add-hover-support-for-inline-snippets-render-tags branch from d26549c to e89192e Compare October 14, 2025 19:31
@shoplando shoplando marked this pull request as ready for review October 14, 2025 19:32
@shoplando shoplando requested a review from a team as a code owner October 14, 2025 19:32
@shoplando shoplando force-pushed the add-hover-support-for-inline-snippets-render-tags branch from e89192e to af0f9a4 Compare October 14, 2025 20:02
@shoplando shoplando force-pushed the render-autocomplete-inline-snippet branch from 122e6f8 to 1751d79 Compare October 14, 2025 20:02
@shoplando shoplando force-pushed the add-hover-support-for-inline-snippets-render-tags branch from af0f9a4 to 98f6aa6 Compare October 14, 2025 20:06
@shoplando shoplando force-pushed the render-autocomplete-inline-snippet branch from 1751d79 to 4467ee0 Compare October 14, 2025 20:06
@shoplando shoplando force-pushed the add-hover-support-for-inline-snippets-render-tags branch from 98f6aa6 to d989d25 Compare October 14, 2025 22:43
@shoplando shoplando force-pushed the render-autocomplete-inline-snippet branch 2 times, most recently from 5b21535 to e008de5 Compare October 15, 2025 14:36
@shoplando shoplando force-pushed the add-hover-support-for-inline-snippets-render-tags branch 4 times, most recently from 166922f to 9da05d3 Compare October 15, 2025 15:44
@shoplando shoplando force-pushed the render-autocomplete-inline-snippet branch 2 times, most recently from 5f6220f to cef145f Compare October 16, 2025 15:38
@shoplando shoplando force-pushed the add-hover-support-for-inline-snippets-render-tags branch 2 times, most recently from 1ed0dff to c9b69b4 Compare October 16, 2025 17:53
@shoplando shoplando force-pushed the render-autocomplete-inline-snippet branch from cef145f to 50eaabe Compare October 16, 2025 17:53
@shoplando shoplando force-pushed the add-hover-support-for-inline-snippets-render-tags branch from c9b69b4 to 701117c Compare October 16, 2025 18:42
@shoplando shoplando force-pushed the render-autocomplete-inline-snippet branch from 50eaabe to aa24f09 Compare October 16, 2025 18:42
dejmedus
dejmedus reviewed Oct 21, 2025
View reviewed changes
...ages/theme-language-server-common/src/hover/providers/RenderSnippetParameterHoverProvider.ts
const rootNode = ancestors[0];
const snippetNode = findInlineSnippet(rootNode, snippetName);
if (snippetNode) {
docDefinition = extractDocDefinition(params.textDocument.uri, snippetNode);
Copy link
Contributor

@dejmedus dejmedus Oct 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into this with the arg completion: since visit grabs all the doc params (even nested), maybe we could re-use the helper function from the other branch we talked about (as I think it grabs the immediate doc tag params)

example Image

@shoplando shoplando force-pushed the add-hover-support-for-inline-snippets-render-tags branch from 701117c to f85fea2 Compare October 21, 2025 20:24
@shoplando shoplando force-pushed the render-autocomplete-inline-snippet branch from aa24f09 to 85ae0e5 Compare October 21, 2025 20:24
@shoplando shoplando force-pushed the add-hover-support-for-inline-snippets-render-tags branch from f85fea2 to 304145e Compare October 22, 2025 16:34
@shoplando shoplando force-pushed the render-autocomplete-inline-snippet branch 2 times, most recently from ba844e6 to 3886acb Compare October 22, 2025 20:13
@shoplando shoplando force-pushed the add-hover-support-for-inline-snippets-render-tags branch 2 times, most recently from 542ee58 to 45efc77 Compare October 22, 2025 20:15
@shoplando shoplando force-pushed the render-autocomplete-inline-snippet branch from 3886acb to 59eb787 Compare October 22, 2025 20:15
@shoplando shoplando force-pushed the add-hover-support-for-inline-snippets-render-tags branch from 45efc77 to 95f6e1e Compare October 22, 2025 20:32
@shoplando shoplando force-pushed the render-autocomplete-inline-snippet branch from 59eb787 to 791ddf5 Compare October 22, 2025 20:32
@shoplando shoplando added the #gsd: 48097 Inline Snippets label Oct 29, 2025 — with Graphite App
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dejmedus dejmedus dejmedus left review comments

Assignees

No one assigned

Labels

#gsd: 48097 Inline Snippets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shoplando @dejmedus