[Stylelint Plugin] Add rule to discourage use of :focus
pseudo class.
#359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/Shopify/web/issues/82233
This PR adds a new Stylelint rule for our CSS, which will emit an error if a developer tries to use the
:focus
CSS pseudo class. We want to encourage use of :focus-visible in it's place, which maintains the essential focus states for users navigating without using a traditional pointer device, but does not show the focus states on certain elements such as links and buttons for users navigating with traditional pointer devices.We have already made a change to Polaris and Web to introduce this change, but we want to ensure folks aren't adding back in
:focus
declarations.