Community framing compares like with like: reported, not resolved#115
Merged
Conversation
"13 sellers mapped / of the community's 1" — the panel line and share text compared the personal contribution count against the community's published-country count, which lags on the two-reporter consensus rule. They now use `reported` from /merchants/stats (distinct sellers with at least one crowd vote): the same universe as the local log, so the community number can never read less than your own. A cached stats blob without the field predates it and is treated as stale; against an old worker the line simply stays hidden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the nonsensical "13 sellers mapped of the community's 1": the panel line and share text compared personal contributions (votes) against published countries (two-reporter consensus). Both now use
reportedfrom /merchants/stats — same universe, so the community number can never read below your own count, and early on it's honest ("13 of the community's 14"). Cached stats blobs without the field are treated as stale; against a not-yet-deployed worker the line hides. Verified live in both shapes. Pairs with knockoff-backend#3 (deploy that first). 212/212 tests, Safari synced.