-
Notifications
You must be signed in to change notification settings - Fork 2
Good first issues: async capture pipeline, Windows fixes, and Antigravity adapter #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kridaydave
wants to merge
7
commits into
Shreyan1:main
Choose a base branch
from
kridaydave:fix/good-first-issues
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c1ce20c
refactor: make capture/bootstrap pipeline async
kridaydave c959ff8
refactor: convert CLI providers to async spawn with stdin prompt
kridaydave ce1dfd4
feat: add Antigravity adapter and CLI provider (parked)
kridaydave 7e6b027
fix: harden persistence with symlink guard and async I/O
kridaydave 16c61a7
fix: Windows CLI/UI fixes and cleanup
kridaydave 11f7c8a
chore: gitignore local debug artifacts
kridaydave 2ce7159
fix: address CodeQL findings (TOCTOU race, dead assignments)
kridaydave File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import { NormalizedHookInput } from './index'; | ||
|
|
||
| export function fromAntigravity(raw: any): NormalizedHookInput { | ||
| const toolCall = (raw.toolCall ?? {}) as Record<string, any>; | ||
| const toolInput = (toolCall.arguments ?? {}) as Record<string, any>; | ||
|
|
||
| const toolName = String(toolCall.name ?? ''); | ||
| const sessionId = String(raw.session_id ?? raw.sessionId ?? ''); | ||
| const rawFilePath = String(toolInput.file_path ?? toolInput.path ?? toolInput.filePath ?? ''); | ||
|
|
||
| const oldContent = toolInput.old_string !== undefined ? String(toolInput.old_string) : (toolInput.oldContent !== undefined ? String(toolInput.oldContent) : undefined); | ||
| const newContent = toolInput.new_string !== undefined ? String(toolInput.new_string) : (toolInput.newContent !== undefined ? String(toolInput.newContent) : (toolInput.content !== undefined ? String(toolInput.content) : undefined)); | ||
| const diff = raw.diff !== undefined ? String(raw.diff) : undefined; | ||
|
|
||
| const edits = Array.isArray(toolInput.edits) | ||
| ? toolInput.edits.map((raw: any) => { | ||
| const e = (raw && typeof raw === 'object') ? raw : {}; | ||
| return { | ||
| old_string: e.old_string !== undefined ? String(e.old_string) : undefined, | ||
| new_string: e.new_string !== undefined ? String(e.new_string) : undefined, | ||
| }; | ||
| }) | ||
| : undefined; | ||
|
|
||
| return { | ||
| toolName, | ||
| filePath: rawFilePath, | ||
| oldContent, | ||
| newContent, | ||
| diff, | ||
| sessionId, | ||
| source: 'antigravity', | ||
| edits | ||
| }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocker, and it's about scope rather than code quality: we deliberately don't wire Antigravity capture yet. See
isAntigravityMigratedindetect.tsand thegemini-antigravity-migrationFAQ entry: because Google relocated hooks into a format it hasn't finalized publicly, we intentionally hold off on capture "rather than register hooks that quietly never run." This adapter guesses the payload shape (toolCall.arguments,write_file, etc.) against a spec that doesn't exist yet, so we can't verify it's correct. Could you dropfromAntigravity(and its entries inALLOWED_ADAPTERS/HOOK_ADAPTERS/supported.ts) from this PR? When Google publishes the format we'll add it properly with a real payload fixture and the full install/detect wiring.