Skip to content

Expand validation coverage and input normalization #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shriii19 merged 1 commit into from
Jun 15, 2026
Merged

Expand validation coverage and input normalization #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 102 additions & 7 deletions backend/middleware/validation.middleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,52 @@ const VALID_TASK_STATUS = [

const VALIDATION_VERSION = 1;

const validationMetrics = {
validationAttempts: 0,
validationFailures: 0,
normalizedInputs: 0,
};

const MAX_USERNAME_LENGTH = 40;
const MAX_TITLE_LENGTH = 120;
const MAX_DESCRIPTION_LENGTH = 1000;

function sanitizeText(value = "") {
return xss(String(value).trim());
}

function normalizeInputValue(
value
) {
if (
value === null ||
value === undefined
) {
return "";
}

validationMetrics.normalizedInputs += 1;

return String(value).trim();
}

function validateRequiredField(
value
) {
return (
normalizeInputValue(value)
.length > 0
);
}

function recordValidationAttempt() {
validationMetrics.validationAttempts += 1;
}

function recordValidationFailure() {
validationMetrics.validationFailures += 1;
}

function buildValidationMetadata(
field,
code
Expand Down Expand Up @@ -55,6 +97,8 @@ function sendValidationFailure(
message,
code
) {
recordValidationFailure();

return res.status(400).json(
transformValidationError(
field,
Expand Down Expand Up @@ -137,12 +181,27 @@ export function validateTask(
position,
} = req.body;

recordValidationAttempt();

if (
!title ||
!req.body ||
typeof req.body !== "object"
) {
return sendValidationFailure(
res,
"request",
"Invalid request payload"
);
}

if (
!validateRequiredField(
title
) ||
!validateLengthRule(
title,
normalizeInputValue(title),
1,
120
MAX_TITLE_LENGTH
)
) {
return sendValidationFailure(
Expand All @@ -155,9 +214,11 @@ export function validateTask(
if (
description &&
!validateLengthRule(
description,
normalizeInputValue(
description
),
0,
1000
MAX_DESCRIPTION_LENGTH
)
) {
return sendValidationFailure(
Expand Down Expand Up @@ -212,12 +273,27 @@ export function validateMessage(
username,
} = req.body;

recordValidationAttempt();

if (
!req.body ||
typeof req.body !== "object"
) {
return sendValidationFailure(
res,
"request",
"Invalid request payload"
);
}

if (
username &&
!validateLengthRule(
username,
normalizeInputValue(
username
),
2,
40
MAX_USERNAME_LENGTH
)
) {
return sendValidationFailure(
Expand Down Expand Up @@ -264,6 +340,19 @@ export function validateFeedItem(
type,
} = req.body;

recordValidationAttempt();

if (
!req.body ||
typeof req.body !== "object"
) {
return sendValidationFailure(
res,
"request",
"Invalid request payload"
);
}

if (
!title ||
!validateLengthRule(
Expand Down Expand Up @@ -328,6 +417,12 @@ export function getValidationMetrics() {
VALIDATION_VERSION,
supportedStatuses:
VALID_TASK_STATUS.length,
validationAttempts:
validationMetrics.validationAttempts,
validationFailures:
validationMetrics.validationFailures,
normalizedInputs:
validationMetrics.normalizedInputs,
timestamp:
Date.now(),
};
Expand Down
Loading