removed DC test structures, removed MM test structures, fixed errors #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test MM loss of SiN in conjunction with the SM PCM.
|
I already have merged your previous one. I'd rather not merge this, as it changes the FloorPlan. I added a new rule in the DFT file specifically for the FAVE couplers, which I implemented via my merge script on the files you submitted already. Download the merged file, and see if it ok as is. Thanks @DantePrins ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding space:
There are 6 files now, if the FaML and FAVE ring8001100 made it onto the chip that would be great, the rest are bracketing.
My fault for not submitting before yesterday.
I removed the DC test structures.
I removed the MM test structures.
errors
I think the multi-mode waveguides test structures were corrupted, they looked fine on my end. I removed them regardless, we can do the measurement on a future chip.
I added floorplans to the submitted files.