Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored iseg hardware layer #234

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Refactored iseg hardware layer #234

merged 7 commits into from
Jan 15, 2025

Conversation

mjmucha
Copy link
Member

@mjmucha mjmucha commented Nov 13, 2024

  • Added get_* and set_* methods for compatibility reasons.
  • Deprecated decorated getter/setter properties, but they are still available for backward compatibility.
  • Refactored code by replacing setup_ps() with init().
  • Added get_current_trip* commands for different Ampere ranges (default Ampere range is now mA).

…ons for compatibility reasons) added get_current_trip* commands for different ampere ranges
Copy link
Contributor

@cbespin cbespin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember the exact reason to move away from @property, but there was one. Rest looks good to me, thanks!

@cbespin cbespin merged commit 9ad7e01 into master Jan 15, 2025
5 checks passed
@cbespin cbespin deleted the iseq_hw_layer_refactor branch January 15, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants