Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase volume concurrency #583

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

n8maninger
Copy link
Member

Increases the sleep time between batches when performing background volume actions. This improves concurrency and usability of the host during these background tasks at the cost of performance. Migrating data from sectors will take at least 5 hours per TiB. IO from slow disks will cause this to be longer since atomicity is very important in migration. This is more performant than explicitly setting an EXCLUSIVE transaction isolation for heavy write transactions.

@n8maninger n8maninger self-assigned this Jan 22, 2025
@n8maninger n8maninger force-pushed the nate/increase-migrate-concurrency branch 5 times, most recently from ddb4c57 to 774f723 Compare January 23, 2025 05:21
@n8maninger n8maninger force-pushed the nate/increase-migrate-concurrency branch from 774f723 to 8d8d193 Compare January 23, 2025 05:35
Copy link
Member

@ChrisSchinnerl ChrisSchinnerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ngl I was a bit confused about the test but when I ran it once with the 1ms jitter I understood 😅

@n8maninger n8maninger merged commit a92e0ca into master Jan 23, 2025
10 checks passed
@n8maninger n8maninger deleted the nate/increase-migrate-concurrency branch January 23, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants