Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fix Shuttle Control Console Syncing #2602

Open
wants to merge 1 commit into
base: dev-sierra
Choose a base branch
from

Conversation

SierraHelper
Copy link
Collaborator

Оригинальный PR: Baystation12#34740

Changelog

🆑 SierraKomodo
bugfix: Shuttle control consoles can no longer be synced to shuttles if not actually on the shuttle.
bugfix: Regular non-overmap shuttle control consoles will no longer function on overmap shuttles, and vice-versa.
tweak: Shuttle control consoles now automatically sync to the shuttle they're built on when created, instead of needing to be set by multitooling the board before creation.
imgadd: Shuttle control consoles that are not properly connected to a shuttle now have a new error screen sprite.
/:cl:

Other Changes

  • Removed /datum/extension/interactive/multitool/circuitboards/shuttle_console
  • Moved shuttle sync logic from shuttle_console circuitboards to the computers via .proc/sync_shuttle() and .proc/is_valid_shuttle().
  • Added an Initialize() parameter to /obj/machinery/computer/shuttle_control for setting the shuttle tag to a specific value instead of syncing to area on creation.
  • Updated /obj/machinery/computer/shuttle_control to automatically syncronize shuttle_tag based on area during Initialize(), if not already set (I.e. by map, subtype, or via the above parameter).

@SierraHelper SierraHelper requested a review from a team as a code owner August 12, 2024 09:43
@github-actions github-actions bot added the ⛰️ Спрайты PR затрагивает спрайты label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪞 MIR ЯОЯ ⛰️ Спрайты PR затрагивает спрайты
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants