Conversation
Coverage Report for CI Build 24884707307Coverage decreased (-0.3%) to 99.111%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions29 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, we used the CMake
find_library()to detect iflibmwas present and should be used for linking. However as the discussion in microsoft/vcpkg#50514 points out,find_library()may fail if the library is inCMAKE_<LANG>_IMPLICIT_LINK_DIRECTORIES. So switch to a different method a detectinglibm.