Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Coverage Report for CI Build 25454050092Warning No base build found for commit Coverage: 99.119%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
cd87db0 to
3d0dcdd
Compare
b40cf5d to
f050c80
Compare
Collaborator
Author
|
I think this PR is ready. It passes all the sanity checks I came up with. Please take a look too, in case there is more to be done. Otherwise I plan to merge it in a couple of days... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functions / methods to calculate offset spherical positions from the reference position along a great circle, which crosses the reference at a specified direction. It is based on the astropy
offset_by()implementation. (thanks to @aleberti).C99 API
Added
novas_offset_by()andnovas_equ_offset_by()to calculate offset spherical / equatorial positions at some distance along a great circle that intersects the original position at the specified angle.C++11 API
Added
Equatorial::offset(),Ecliptic::offset(),Galactic::offset(), andHorizontal::offset().