Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need two of these? :) #273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

MinorX
Copy link

@MinorX MinorX commented Aug 24, 2024

Summary by Sourcery

Remove trailing whitespace from the end of the file.

Copy link

sourcery-ai bot commented Aug 24, 2024

Reviewer's Guide by Sourcery

This pull request removes a single empty line at the end of the file 'bot/helper/mirror_utils/upload_utils/ddlserver/gofile.py'. The change is minimal and does not affect the functionality of the code.

File-Level Changes

Change Details Files
Removal of an empty line at the end of the file
  • Deleted an empty line at the end of the file
bot/helper/mirror_utils/upload_utils/ddlserver/gofile.py

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MinorX - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider keeping the trailing newline at the end of the file. It's a POSIX standard and can prevent issues with certain tools and scripts.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant