refactor(guildhall): rename graft → adoption#10
Merged
Conversation
…moke The "graft" term for applying an aspect to a component grated: it sits in a third register (botanical — neither the Norse kennings nor plain-technical), and the American-English "graft = corruption" reading is a live risk for the corporate port. Rename it to the industry-plain **adoption**. Mapping, chosen for consistency with the existing vocabulary (components already "adopt" an aspect; the record is "enrollment"): - graft (the mechanism / §3.7 concept) → adoption - the graft / graft Template (the scaffolder-door artifact) → adoption template - graft / grafting (verb, "graft X onto Y") → apply (the model's existing verb) - annotation `siliconsaga.org/graft-record` → `siliconsaga.org/adoption-record` - enrollment is unchanged — it remains the record: you run an *adoption* (adoption template + SKILL.md), which *enrolls* the component. ADR 0010 renamed to `0010-aspect-module-adoption-blocks.md` (nav + index refs updated). Norse skin candidates (kvistr/sproti/ívaf) were set aside in favour of the plain industry term; the kennings layer can still skin it later if wanted. Verified: `make smoke-catalog` passes 16/16, including the renamed "Adoption Template ingested / ownedBy" assertions — the seed still ingests at runtime with its relations intact. No entity refs, template ids, or group names changed (`apply-security-aspect`, `security-gildi` untouched); the `-record` annotation is inert (not yet consumed). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (18)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR replaces graft terminology with adoption across ADRs, design documents, demo materials, example catalog data, annotations, template descriptions, and smoke-catalog checks. It also renames the ADR navigation target and validates the ChangesAdoption terminology alignment
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
siliconsaga.org/graft-record→siliconsaga.org/adoption-record. Enrollment is unchanged — you run an adoption (adoption template +SKILL.md), which enrolls the component.0010-aspect-module-adoption-blocks.md(mkdocs nav + ADR index refs updated). Norse skin candidates (kvistr/sproti/ívaf) were set aside for the plain term; the kennings layer can still skin it later.apply-security-aspect,security-gildiuntouched); the-recordannotation is inert (not yet consumed).Test plan
make smoke-catalogpasses 16/16, including the renamed "Adoption Template ingested / ownedBy security-gildi" assertions — the seed still ingests at runtime with its relations intact.Related
gildi) hub-page plugin work.