Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nbt): add serializers for tags and item stack #40

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

SettingDust
Copy link

@SettingDust SettingDust commented Sep 27, 2022

No description provided.

@SettingDust SettingDust mentioned this pull request Sep 27, 2022
3 tasks
@SettingDust

This comment was marked as off-topic.

TODO: add unit tests for serializers
@SettingDust SettingDust marked this pull request as ready for review October 4, 2022 10:35
@SettingDust

This comment was marked as outdated.

@jakobkmar
Copy link
Member

Thanks, will check it out in a few days, ping me if I forget it.

@SettingDust

This comment was marked as resolved.

@jakobkmar
Copy link
Member

Looking good so far - cloned it locally, I'll add a few commits to this PR and then request a review from f0x.

@SettingDust

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants