-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed bug that leads to 1D linear material not behaving properly in simulations #108
base: master
Are you sure you want to change the base?
Conversation
…n copying a line over, and I didn't realize. Hopefully it builds now?
@mrp089 should be good to merge! Please take a look when you get time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for doing this, @JRao-rgb! Please see my comments and ask me if you have any questions. Congratulations on your first pull request!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check out this file from master branch because there are only formatting changes in here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to do one of these tests with " So_/S
would always be close to one, right?
@@ -88,7 +88,9 @@ cvOneDMaterialLinear& cvOneDMaterialLinear::operator=(const cvOneDMaterialLinear | |||
} | |||
|
|||
void cvOneDMaterialLinear::SetEHR(double ehr_val, double pref_val){ | |||
ehr = ehr_val; | |||
ehr = 4.0/3.0*ehr_val; // JR 15/11/23: multiplied EHR by the correct factor (since downstream analysis using EHR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add date and initials (even though people did it before), that's now all stored in git
. You can check it out by doing a git blame
on a file.
Current situation
#110
I found out the linear material model is broken when I was testing the backwards compatibility of the leaky vessels code with previous sv input files. I initially thought it was my code that was broken, but the code just didn't handle linear materials properly.
Release Notes
Documentation
Testing
Please ensure that the PR meets the testing requirements set by GitHub Actions.
Code of Conduct & Contributing Guidelines