-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addtestcasesbif issue53 #61
Conversation
…ditions with advective, stabilization, and distal pressure
…d the flow test cases that are not supported
@melodydong This looks great, especially the documentation!! I added automatic result testing in 31a6021. Can you add your tests to the testing framework in After that I think it's ready to merge. Thanks for your help! |
…stcasesbif_issue53
…stcasesbif_issue53
…Solver into addtestcasesbif_issue53
Thanks @melodydong for adding these comprehensive tests to the framework! It fails currently, but I think that's only minor notation. I can fix that. I've seen that the test |
@mrp089, thanks for fixing the notation. For the bifurcation_RCR test, I found that the 1D solver as is, was only comparable within that 10% tolerance. It's possible that it would be closer if I wrote out more steps during the simulation to exactly capture the true max and min, though I didn't explore that possibility. It could also be that the 0D rcr results interpolated the inflow slightly differently. I think the 1D solver is solving the RCR boundary conditions correctly and it might just be slight differences in interpreting the max/min values or the sensitivity of the max/min values between 0D and 1D. |
Added test cases for testing issue #53