Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addtestcasesbif issue53 #61

Merged
merged 11 commits into from
Jun 16, 2020
Merged

Addtestcasesbif issue53 #61

merged 11 commits into from
Jun 16, 2020

Conversation

melodydong
Copy link
Collaborator

Added test cases for testing issue #53

@melodydong melodydong requested a review from mrp089 June 3, 2020 03:48
@mrp089
Copy link
Member

mrp089 commented Jun 11, 2020

@melodydong This looks great, especially the documentation!!

I added automatic result testing in 31a6021. Can you add your tests to the testing framework in test/run_tests.py? Let me know if you have any questions on how to do that.

After that I think it's ready to merge. Thanks for your help!

@mrp089
Copy link
Member

mrp089 commented Jun 13, 2020

Thanks @melodydong for adding these comprehensive tests to the framework! It fails currently, but I think that's only minor notation. I can fix that.

I've seen that the test bifurcation_RCR tests quantities to 10% tolerance. Is there a reason why the tolerance is that high in that specific test?

@melodydong
Copy link
Collaborator Author

@mrp089, thanks for fixing the notation. For the bifurcation_RCR test, I found that the 1D solver as is, was only comparable within that 10% tolerance. It's possible that it would be closer if I wrote out more steps during the simulation to exactly capture the true max and min, though I didn't explore that possibility. It could also be that the 0D rcr results interpolated the inflow slightly differently. I think the 1D solver is solving the RCR boundary conditions correctly and it might just be slight differences in interpreting the max/min values or the sensitivity of the max/min values between 0D and 1D.

@mrp089 mrp089 merged commit cb0b916 into master Jun 16, 2020
@mrp089 mrp089 deleted the addtestcasesbif_issue53 branch July 17, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants