-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function input feature for time-dependent boundary conditions #108
base: master
Are you sure you want to change the base?
Conversation
Initial implementation of a time-dependent flow BC from an expression string. Currently results in a SEGFAULT.
Finished debugging time-dependent flow block
I ran the
You need to add catching exceptions in the Python testing code. |
We don't want to mix external software with our source code so the |
Also I see that there is Docker container file in |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
===========================================
- Coverage 79.25% 25.12% -54.14%
===========================================
Files 52 53 +1
Lines 2179 15401 +13222
Branches 278 1405 +1127
===========================================
+ Hits 1727 3869 +2142
- Misses 452 11532 +11080 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready! Just some minor comments.
Initial implementation of a time-dependent flow BC from an expression string. Currently results in a SEGFAULT.
Finished debugging time-dependent flow block
640f3e7
to
563ac27
Compare
563ac27
to
267e419
Compare
f7f81ff
to
4a65796
Compare
Current situation
Closes #89
Release Notes
fn
to flow and pressure boundary conditions that takes in a stringt
t
= the current time value.Documentation
Time-dependent boundary conditions can now be input using a function passed in as a string. The function is of the variable
t
, or time. For example:"bc_values": { "fn": "2.0 * (4*atan(1.)) * COS(2.0 * (4*atan(1.)) * t)" }
Testing
Test case
test_time_dependent_block
added totest_io.py
, which runs json filestimeDep_Flow.json
andtimeDep_Pressure.json
.Code of Conduct & Contributing Guidelines