Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory issue and add functionality to python interface #93

Merged
merged 18 commits into from
Jan 18, 2024

Conversation

menon-karthik
Copy link
Member

@menon-karthik menon-karthik commented Dec 29, 2023

Current situation

Closes #92 and #82.

Release Notes

Testing

Tests are passing. I haven't added new tests for update_block_params and read_block_params in the python interface. Need to think about how to test that within the current testing framework.

Code of Conduct & Contributing Guidelines

@menon-karthik menon-karthik self-assigned this Dec 29, 2023
@menon-karthik menon-karthik added bug Something isn't working enhancement New feature or request labels Dec 29, 2023
@menon-karthik
Copy link
Member Author

Update: I broke something by trying to rebase with master after all the name changes. So this is not ready yet.

@menon-karthik
Copy link
Member Author

Ready now!

@menon-karthik menon-karthik requested a review from mrp089 January 13, 2024 03:25
Copy link
Member

@mrp089 mrp089 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @menon-karthik! Thank you for adding more documentation and error handling on the go!

@mrp089 mrp089 merged commit 208c094 into SimVascular:master Jan 18, 2024
@menon-karthik menon-karthik deleted the sbi branch February 13, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
2 participants