Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storybook inspector height #47

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Fix storybook inspector height #47

merged 3 commits into from
Nov 8, 2022

Conversation

HakimCh
Copy link
Contributor

@HakimCh HakimCh commented Nov 7, 2022 •
edited
Loading

Description

  • Remove the SET_HEIGHT event's target, it causes infinite loop when it's fired.
  • Remove unused constant.

Fixes (#45)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Housekeeping (non-breaking change)

How Has This Been Tested?

  1. Link the package
  2. Create new component A with basic machine
  3. Create new story for the component A
  4. Set inspector height to 500px
  5. The visualizer loaded with the correct height

Test Configuration:

  • Storybook: 6.5.10

SimeonC
SimeonC approved these changes Nov 8, 2022
View reviewed changes
Copy link
Owner

@SimeonC SimeonC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for investigating and fixing the issue.

@SimeonC SimeonC merged commit 4ca93f5 into SimeonC:main Nov 8, 2022
@SimeonC
Copy link
Owner

SimeonC commented Nov 9, 2022

🚀 PR was released in v2.3.6 🚀

@SimeonC
Copy link
Owner

SimeonC commented Nov 9, 2022

🚀 PR was released in v2.3.6 🚀

1 similar comment
@SimeonC
Copy link
Owner

SimeonC commented Nov 9, 2022

🚀 PR was released in v2.3.6 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimeonC SimeonC SimeonC approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HakimCh @SimeonC