Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inspector): watch viewMode for change to avoir rerender #53

Merged
merged 1 commit into from
May 2, 2023
Merged

fix(inspector): watch viewMode for change to avoir rerender #53

merged 1 commit into from
May 2, 2023

Conversation

HakimCh
Copy link
Contributor

@HakimCh HakimCh commented Apr 30, 2023

Description

  • watch context.viewMode updates to reload the Story correctly

Fixes (#45)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  1. Clone the provided test repo (https://github.com/TheKnarf/storybook-xstate-test)
  2. Link the package
  3. Select docs tab
  4. Go back to story tab
  5. The Story & visualizer loaded correctly.

Test Configuration:

  • Storybook: 6.5.10

@SimeonC SimeonC merged commit e3df648 into SimeonC:main May 2, 2023
@SimeonC
Copy link
Owner

SimeonC commented May 2, 2023

🚀 PR was released in v2.3.7 🚀

@SimeonC
Copy link
Owner

SimeonC commented May 2, 2023

Thanks for the PR and fixing the issue!

@HakimCh
Copy link
Contributor Author

HakimCh commented May 2, 2023

Thanks for taking the time to review and merge my pull request! It's always great to contribute and help solve the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimeonC SimeonC SimeonC approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HakimCh @SimeonC