-
Notifications
You must be signed in to change notification settings - Fork 1
2.0.1 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
2.0.1 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR (version "2.0.1") updates the handling of file paths and logging details across multiple components.
- In SessionProxyApp.kt, the metadata storage directory is now explicitly set to a "metadatadb" subdirectory.
- In DaemonClient.kt, logic for determining the home directory is centralized in a new getHome() function and the PID file is now resolved relative to that directory.
- In HSQLMetadataStorage.kt, the logging call is simplified to remove unnecessary exception stack trace logging.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| intellij/src/main/kotlin/aicoder/actions/SessionProxyApp.kt | Updates the metadataStorage initialization to use a subdirectory for the database. |
| desktop/src/main/kotlin/com/simiacryptus/cognotik/DaemonClient.kt | Refactors session directory creation and PID file path resolution by introducing getHome(). |
| core/src/main/kotlin/com/simiacryptus/cognotik/platform/hsql/HSQLMetadataStorage.kt | Streamlines logging by removing the RuntimeException argument from log.info. |
…and dark. With a glint in his eye, And a nut supply high, He ruled every tree and every bark. His name was Big Vinnie the Claw, The meanest the rodent world saw. With a swipe and a bite, He'd settle a fight, And his enemies fled in pure awe. He'd shake down the chipmunks for loot, While chewing his nuts in a suit. He'd mutter and swear, From his cold wooden lair, Packing heat in the form of a boot. The pigeons paid tribute in bread, Or they'd find their best nests full of dread. He ran rackets on bees, Sold protection to trees, And he dined while his rivals dropped dead. The winters were brutal and long, But Vinnie the Claw stayed strong. While the weak froze or fled, He'd feast on their bread, Humming old gangster war songs. But one fall, a young hawk took flight, And Vinnie looked up — too late, no fight. With a screech and a dive, Only rumors survive: That Big Vinnie still haunts the night.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.