Skip to content

fix: stabilize extension detail open settings e2e #3082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SimonSiefke wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: stabilize extension detail open settings e2e #3082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4692ec9
test: reproduce extension settings e2e failure
SimonSiefke Jul 18, 2026
4e0ca25
fix: update extension detail tab state assertions
SimonSiefke Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,56 @@ on:
- main

jobs:
diagnose-extension-detail-view-open-settings:
name: extension-detail-view-open-settings (attempt ${{ matrix.attempt }})
runs-on: ubuntu-24.04
strategy:
fail-fast: false
max-parallel: 1
matrix:
attempt: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20]
timeout-minutes: 30
steps:
- uses: actions/checkout@v7
- uses: actions/setup-node@v7
with:
node-version-file: '.nvmrc'
- name: Compute node modules cache key
id: nodeModulesCacheKey
run: echo "value=$(node scripts/computeNodeModulesCacheKey.js)" >> $GITHUB_OUTPUT
shell: bash
- uses: actions/cache@v6
id: npm-cache
with:
path: |
**/node_modules
**/.vscode-test
**/.vscode-user-data-dir
**/.vscode-ffmpeg
**/.vscode-resolve-source-map-cache
key: ${{ runner.os }}-cacheNodeModules-${{ steps.nodeModulesCacheKey.outputs.value }}
- name: npm ci
run: npm ci --ignore-scripts && npm run postinstall
if: steps.npm-cache.outputs.cache-hit != 'true'
- run: npm run build
- name: Run exact e2e test
uses: coactions/setup-xvfb@v1
with:
run: >-
node packages/cli/bin/test.js
--cwd packages/e2e
--only ^extension-detail-view-open-settings.ts
--run-skipped-tests-anyway
--record-video
--workers 1
- uses: actions/upload-artifact@v7
if: always()
with:
name: extension-detail-view-open-settings-attempt-${{ matrix.attempt }}
path: ./.vscode-videos
include-hidden-files: true
if-no-files-found: ignore

pr:
runs-on: ${{ matrix.os }}
strategy:
Expand Down
4 changes: 2 additions & 2 deletions packages/page-object/src/parts/ExtensionsDetailView/ExtensionsDetailView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export const create = ({ expect, page, VError }: CreateParams) => {
await page.waitForIdle()
await tab.click()
await page.waitForIdle()
await expect(tab).toHaveAttribute('aria-checked', 'true')
await expect(tab).toHaveAttribute('aria-pressed', 'true')
await page.waitForIdle()
if (options && options.webView) {
const webView = page.locator('.webview')
Expand Down Expand Up @@ -139,7 +139,7 @@ export const create = ({ expect, page, VError }: CreateParams) => {
hasText: text,
})
await expect(tab).toBeVisible()
await expect(tab).toHaveAttribute('aria-checked', 'true')
await expect(tab).toHaveAttribute('aria-pressed', 'true')
} catch (error) {
throw new VError(error, `Failed to verify extension detail tab ${text}`)
}
Expand Down
Loading