Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,62 @@ on:
- main

jobs:
diagnose-output-select:
name: output-select (attempt ${{ matrix.attempt }})
runs-on: ubuntu-24.04
strategy:
fail-fast: false
max-parallel: 1
matrix:
attempt: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20]
timeout-minutes: 30
steps:
- uses: actions/checkout@v7
- uses: actions/setup-node@v7
with:
node-version-file: '.nvmrc'
- name: Compute node modules cache key
id: nodeModulesCacheKey
run: echo "value=$(node scripts/computeNodeModulesCacheKey.js)" >> $GITHUB_OUTPUT
shell: bash
- uses: actions/cache@v6
id: npm-cache
with:
path: |
**/node_modules
**/.vscode-test
**/.vscode-user-data-dir
**/.vscode-ffmpeg
**/.vscode-resolve-source-map-cache
key: ${{ runner.os }}-cacheNodeModules-${{ steps.nodeModulesCacheKey.outputs.value }}
- name: npm ci
run: npm ci --ignore-scripts && npm run postinstall
if: steps.npm-cache.outputs.cache-hit != 'true'
- run: npm run build
- name: Run output-select diagnostic attempt ${{ matrix.attempt }}
uses: coactions/setup-xvfb@v1
with:
run: >-
node packages/cli/bin/test.js
--cwd packages/e2e
--check-leaks
--measure-after
--measure detached-dom-nodes-with-stack-traces
--restart-between
--run-skipped-tests-anyway
--only ^output-select.ts
--workers 1
--record-video
- uses: actions/upload-artifact@v7
if: always()
with:
name: output-select-attempt-${{ matrix.attempt }}
path: |
./.vscode-memory-leak-finder-results
./.vscode-videos
include-hidden-files: true
if-no-files-found: ignore

pr:
runs-on: ${{ matrix.os }}
strategy:
Expand Down
3 changes: 1 addition & 2 deletions packages/page-object/src/parts/Output/Output.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,7 @@ export const create = ({ electronApp, expect, ideVersion, page, platform, VError
await quickPick.select(channelName)
await expect(select).toHaveValue(channelName)

const nameLower = channelName.toLowerCase()
const editor = page.locator(`.monaco-editor[data-uri^="output:${nameLower}"]`)
const editor = outputView.locator('.monaco-editor')
await expect(editor).toBeVisible()
await page.waitForIdle()

Expand Down
Loading