Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canister Texture Porting #1028

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Canister Texture Porting #1028

wants to merge 4 commits into from
+1 −1

Conversation

CilliePaint
Copy link
Contributor

Description

This Pull Request seeks to start the porting of BayStation Textures to the EE engine, starting off with Canisters. These Canisters are from a 2022 PR of BayStation and are the latest of their texturing.

Media

Example Media Embed

Changelog

🆑

  • tweak: Atmos tanks have been given a fresh new design, Atmosians rejoice!

@CilliePaint
Canister Baystation Texture Porting
06ab076 
Merely ports the textures of BayStation's rather beautiful Canisters over, I forgot the Meta File here so I'll fix that in another commit :P

Signed-off-by: Miller <[email protected]>
@CilliePaint
Update meta.json
afb9a05 
Signed-off-by: Miller <[email protected]>
@github-actions github-actions bot added the Changes: Sprite Changes any png or json in an RSI label Oct 9, 2024
@SimpleStation14 SimpleStation14 changed the title Canister texture porting Canister Texture Porting Oct 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

RSI Diff Bot; head commit e3e52a2 merging into dde6130
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Storage/canister.rsi

State Old New Status
black-1 Modified
black Modified
blue-1 Modified
blue Modified
can-connector Modified
can-o0 Modified
can-o1 Modified
can-o2 Modified
can-o3 Modified
can-open Modified
darkblue-1 Modified
darkblue Modified
frezon-1 Modified
frezon Modified
grey-1 Modified
grey Modified
locked Modified
orange-1 Modified
orange Modified
red-1 Modified
red Modified
redws-1 Modified
redws Modified
scrubber-connector Modified
unlocked Modified
water_vapor-1 Modified
water_vapor Modified
yellow-1 Modified
yellow Modified

Edit: diff updated after e3e52a2

@Mnemotechnician
Copy link
Contributor

finally, explosive barrels in ss14

@CilliePaint
Copy link
Contributor Author

finally, explosive barrels in ss14

make sure to shoot them

@FoxxoTrystan FoxxoTrystan requested review from a team, VMSolidus, FoxxoTrystan, DEATHB4DEFEAT, Peptide90, Pspritechologist and OldDanceJacket and removed request for a team October 9, 2024 19:04
@FoxxoTrystan FoxxoTrystan added Size: 4-Small For small issues/PRs Priority: 3-Medium Needs to be resolved at some point Type: Port Brings something to here from another codebase labels Oct 9, 2024
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Oct 9, 2024
FoxxoTrystan
FoxxoTrystan requested changes Oct 9, 2024
View reviewed changes
Copy link
Member

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some missing files?

Files can-oa1.png and red.png are still unmodified, and pretty sure thats not indended.

@CilliePaint
Copy link
Contributor Author

Is there some missing files?

Files can-oa1.png and red.png are still unmodified, and pretty sure thats not indended.

yeah, couldn't figure out what oa1 actually was, i did just forget the red.png one though, oopsies

@CilliePaint
Copy link
Contributor Author

oa1 is a unused texture, so i didn't change it, forgot to say that......

VMSolidus
VMSolidus requested changes Oct 13, 2024
View reviewed changes
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually these could totally be added as new "High Capacity Canister" objects, rather than replace our similar, admittedly pretty nice canister sprites from Paradise. :)

@Evgencheg
Copy link
Contributor

Actually these could totally be added as new "High Capacity Canister" objects, rather than replace our similar, admittedly pretty nice canister sprites from Paradise. :)

Yea, good idea. I want to add this now…

@CilliePaint
Copy link
Contributor Author

Actually these could totally be added as new "High Capacity Canister" objects, rather than replace our similar, admittedly pretty nice canister sprites from Paradise. :)

I am not particularly good with programming, especially in SS14's jank-ass codebase, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VMSolidus VMSolidus VMSolidus requested changes

@FoxxoTrystan FoxxoTrystan FoxxoTrystan approved these changes

@DEATHB4DEFEAT DEATHB4DEFEAT Awaiting requested review from DEATHB4DEFEAT DEATHB4DEFEAT was automatically assigned from Simple-Station/ee-writers

@Peptide90 Peptide90 Awaiting requested review from Peptide90 Peptide90 was automatically assigned from Simple-Station/ee-writers

@Pspritechologist Pspritechologist Awaiting requested review from Pspritechologist Pspritechologist was automatically assigned from Simple-Station/ee-writers

@OldDanceJacket OldDanceJacket Awaiting requested review from OldDanceJacket OldDanceJacket was automatically assigned from Simple-Station/ee-writers

Requested changes must be addressed to merge this pull request.

Assignees

@CilliePaint CilliePaint

Labels
Changes: Sprite Changes any png or json in an RSI Priority: 3-Medium Needs to be resolved at some point Size: 4-Small For small issues/PRs Status: Needs Review Someone please review this Type: Port Brings something to here from another codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CilliePaint @Mnemotechnician @Evgencheg @VMSolidus @FoxxoTrystan