Skip to content

Fix AddTrait And ReplaceTrait Functions #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

VMSolidus
Copy link
Member

Description

Maintainer suggested changes broke the AddTrait and ReplaceTrait functionality of the Version 2 Trait Functions. This restores their functionality.

Changelog

🆑

  • fix: Fixed AddTrait and ReplaceTrait functions giving players an unmodified, completely default component.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Nov 8, 2024
@FoxxoTrystan FoxxoTrystan requested review from a team, Aidenkrz, FoxxoTrystan, Remuchi, DEATHB4DEFEAT, Peptide90, Pspritechologist and OldDanceJacket and removed request for a team November 9, 2024 19:14
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Nov 9, 2024
@FoxxoTrystan FoxxoTrystan added Priority: 2-High Needs to be resolved as soon as possible Size: 5-Very Small For especially small issues/PRs Type: Bug [Un]intentional issue with something labels Nov 9, 2024
@VMSolidus VMSolidus merged commit 4de7f50 into Simple-Station:master Nov 10, 2024
20 checks passed
FoxxoTrystan pushed a commit to FoxxoTrystan/Einstein-Engines that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Priority: 2-High Needs to be resolved as soon as possible Size: 5-Very Small For especially small issues/PRs Status: Needs Review Someone please review this Type: Bug [Un]intentional issue with something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants