Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine Update v233.0.0 #1227

Closed
wants to merge 137 commits into from
Closed

Conversation

sleepyyapril
Copy link
Contributor

@sleepyyapril sleepyyapril commented Nov 15, 2024

Description

The latest version we can get to without problems!


SEE #1220

DO NOT MERGE.

sleepyyapril and others added 23 commits November 13, 2024 21:41
* Update submodule to 228.0.0

* Fix every single test

* Also this one
* partial buckling refactor

* git mv test

* change test namespace

* git mv test

* Update test namespace

* Add pulling test

* Network BuckleTime

* Add two more tests

* smelly
* Replaced uses of Dirty(Component) with Dirty(Uid, Component)
Modified some systems (notably pulling-related) to use uids.

* Missed a few

* Revert changes to pulling

* No
* Update submodule to 228.0.0

* Fix every single test

* Also this one
* Fix storage UI interactions

* Add VV support
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Nov 15, 2024
@sleepyyapril sleepyyapril changed the title V229.1.4 Engine Update v229.1.4 Nov 15, 2024
sleepyyapril and others added 23 commits November 16, 2024 01:11
* Make vox roundstart

I believe all the issues are fixed.

* Click detection bandaid

* Make clickable 1% nicer

Still bad. Still doesn't handle multi-viewports well.
* move MinMax to shared

* cleanup MinMax

* move other ticking components to shared just because

* remove unused prototype file

* update everything to use shared components

* test

* test 2

* test 3

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
* Make anomaly, artifact and gifts events announcement sound optional

* Requested changes + Added new "GameRuleAfterAddedEvent" for StationEventSystem

We need to call "Add" in "StationEventSystem" after others GameRule's in case if we need to change StationEventComponent variables.

* Fix margins

* Makes use of GameRuleComponent.Delay and remove station system handling of delays plus small cleanup

* Fix merge

---------

Co-authored-by: AJCM <[email protected]>
@github-actions github-actions bot added the Changes: Localization Changes any ftl files label Nov 16, 2024
@sleepyyapril
Copy link
Contributor Author

This is NOT stable.

@sleepyyapril sleepyyapril marked this pull request as draft November 16, 2024 09:34
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Nov 16, 2024
@sleepyyapril sleepyyapril deleted the v229.1.4 branch November 16, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files Holy Shit Priority: 3-Medium Needs to be resolved at some point Size: 3-Medium For medium issues/PRs Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.