Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Day/Night Time Cycle For Maps #1234

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Day/Night Time Cycle For Maps #1234

merged 4 commits into from
Nov 18, 2024

Conversation

DocNITE
Copy link
Contributor

@DocNITE DocNITE commented Nov 17, 2024 •
edited
Loading

Description

Add real world Day/Night cycle changing, with Ambient color interpolation and some configurable features for mappers.
High inspired by Nuclear-14 and Crystall Punk 14

TimeCycle use 24h day calculation, instead coefficient, like in N14.

TODO

[ ] - Add more examples/prepared map palettes for Day/Night ambient.
[ ] - (Optional) Move all palette description into List of variables, instead calling IPrototypeManager every minute passing.

demo.mp4

image

Changelog

🆑

  • add: Added Day/Night time cycle for admins and mapers.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Nov 17, 2024
@DocNITE
Copy link
Contributor Author

DocNITE commented Nov 17, 2024

I don't sure - should i calculate day cycle in coefficient/percentage. So, if you have any idea - "tell" me 👀

VMSolidus
VMSolidus requested changes Nov 17, 2024
View reviewed changes
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, pretty simple changes to do here.

Content.Shared/TimeCycle/TimeCycleComponent.cs Outdated Show resolved Hide resolved
Content.Server/TimeCycle/TimeCycleSystem.cs Outdated Show resolved Hide resolved
Content.Server/TimeCycle/TimeCycleSystem.cs Outdated Show resolved Hide resolved
Content.Server/TimeCycle/TimeCycleSystem.cs Outdated Show resolved Hide resolved
Content.Server/TimeCycle/TimeCycleSystem.cs Outdated Show resolved Hide resolved
@DocNITE DocNITE requested a review from VMSolidus November 17, 2024 20:48
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Nov 17, 2024
@Aidenkrz Aidenkrz added Size: 4-Small For small issues/PRs Priority: 5-Whenever Doesn't matter when this gets resolved Type: Feature Creation of or significant changes to a feature Status: Awaiting Merge 2 or more maintainers has approved this PR and is now awaiting merge and removed Status: Needs Review Someone please review this labels Nov 18, 2024
@VMSolidus VMSolidus merged commit ab0fa7c into Simple-Station:master Nov 18, 2024
12 checks passed
sleepyyapril pushed a commit to sleepyyapril/Einstein-Engines that referenced this pull request Nov 18, 2024
@SimpleStation14
Automatic Changelog Update (Simple-Station#1234)
460f444
@PuroSlavKing PuroSlavKing mentioned this pull request Nov 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aidenkrz Aidenkrz Aidenkrz approved these changes

@VMSolidus VMSolidus VMSolidus approved these changes

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Priority: 5-Whenever Doesn't matter when this gets resolved Size: 4-Small For small issues/PRs Status: Awaiting Merge 2 or more maintainers has approved this PR and is now awaiting merge Type: Feature Creation of or significant changes to a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DocNITE @VMSolidus @Aidenkrz