Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Dangerous Mindbreaking #1249

Merged

Conversation

VMSolidus
Copy link
Member

@VMSolidus VMSolidus commented Nov 19, 2024

Description

Somehow people weren't getting the memo despite the HORRIFYING texts associated with Mindbreaking, that doing so is an almost comically evil act akin to murder. So this PR fixes that. By making it even more obvious.

Media

image

Changelog

🆑

  • add: Added a server option for "Scarier Mindbreaking". Mindbreaking now irreversibly converts a player character into a non-sentient NPC.
  • fix: Mindbreaking now only works on Psychics.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Nov 19, 2024
@bruhmogus
Copy link

will this be on or off by default, since LSD + hypospray is able to really fuck up balance (just a tad)

@VMSolidus
Copy link
Member Author

will this be on or off by default, since LSD + hypospray is able to really fuck up balance (just a tad)

Just don't take the Latent Psychic trait.
faridaiscute

@bruhmogus
Copy link

will this be on or off by default, since LSD + hypospray is able to really fuck up balance (just a tad)

Just don't take the Latent Psychic trait.

iirc you can mindbreak someone who isnt even a psionic

@VMSolidus
Copy link
Member Author

will this be on or off by default, since LSD + hypospray is able to really fuck up balance (just a tad)

Just don't take the Latent Psychic trait.

iirc you can mindbreak someone who isnt even a psionic

I'm going to fix that right now

@VMSolidus
Copy link
Member Author

will this be on or off by default, since LSD + hypospray is able to really fuck up balance (just a tad)

Just don't take the Latent Psychic trait.

iirc you can mindbreak someone who isnt even a psionic

Done.
image

@bruhmogus
Copy link

also how will this play with the trait that literally gives you the mindbroken component roundstart

@VMSolidus
Copy link
Member Author

also how will this play with the trait that literally gives you the mindbroken component roundstart

It doesn't.
Chadly

@bruhmogus
Copy link

also how will this play with the trait that literally gives you the mindbroken component roundstart

It doesn't.

hm. maybe it should, but at the same time it'd be hilarious to instantly get ghosted for having the trait

@gluesniffler
Copy link
Contributor

gluesniffler commented Nov 19, 2024

also how will this play with the trait that literally gives you the mindbroken component roundstart

It doesn't.

hm. maybe it should, but at the same time it'd be hilarious to instantly get ghosted for having the trait

It's better this way, because then you have to doubt whether or not the person you're talking to is an "NPC" or not IC, giving you more leeway to abuse them (killing a mindbroken person at best counts as animal abuse)

@VMSolidus
Copy link
Member Author

also how will this play with the trait that literally gives you the mindbroken component roundstart

It doesn't.

hm. maybe it should, but at the same time it'd be hilarious to instantly get ghosted for having the trait

It's better this way, because then you have to doubt whether or not the person you're talking to is an "NPC" or not IC, giving you more leeway to abuse them (killing a mindbroken person at best counts as animal abuse)

It would be even funnier if we rebased the NPCConversationSystem from Nyano, and/or make the mindbroken NPCs talk using ChatGPT2.

@bruhmogus
Copy link

also how will this play with the trait that literally gives you the mindbroken component roundstart

It doesn't.

hm. maybe it should, but at the same time it'd be hilarious to instantly get ghosted for having the trait

It's better this way, because then you have to doubt whether or not the person you're talking to is an "NPC" or not IC, giving you more leeway to abuse them (killing a mindbroken person at best counts as animal abuse)

this confuses me, have we tested what actually happens if someone has the instant mindbreak trait? will it insta-ghost? will it let them keep playing?

@VMSolidus
Copy link
Member Author

also how will this play with the trait that literally gives you the mindbroken component roundstart

It doesn't.

hm. maybe it should, but at the same time it'd be hilarious to instantly get ghosted for having the trait

It's better this way, because then you have to doubt whether or not the person you're talking to is an "NPC" or not IC, giving you more leeway to abuse them (killing a mindbroken person at best counts as animal abuse)

this confuses me, have we tested what actually happens if someone has the instant mindbreak trait? will it insta-ghost? will it let them keep playing?

It doesn't lmao. It doesn't even call this function.

@bruhmogus
Copy link

also how will this play with the trait that literally gives you the mindbroken component roundstart

It doesn't.

hm. maybe it should, but at the same time it'd be hilarious to instantly get ghosted for having the trait

It's better this way, because then you have to doubt whether or not the person you're talking to is an "NPC" or not IC, giving you more leeway to abuse them (killing a mindbroken person at best counts as animal abuse)

this confuses me, have we tested what actually happens if someone has the instant mindbreak trait? will it insta-ghost? will it let them keep playing?

It doesn't lmao. It doesn't even call this function.

oh! thats perfect! as someone with Zero Maintainer Authority™ i'd say this works really well

Copy link
Contributor

@sleepyyapril sleepyyapril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set default CVar value to false. This is an extreme change.

@FoxxoTrystan FoxxoTrystan added Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs labels Nov 19, 2024
@FoxxoTrystan FoxxoTrystan requested review from a team, Aidenkrz, FoxxoTrystan, Remuchi, DEATHB4DEFEAT, Peptide90 and Pspritechologist and removed request for a team November 19, 2024 14:51
@FoxxoTrystan FoxxoTrystan added the Status: Needs Review Someone please review this label Nov 19, 2024
@Erisfiregamer1
Copy link
Contributor

also how will this play with the trait that literally gives you the mindbroken component roundstart

It doesn't.

hm. maybe it should, but at the same time it'd be hilarious to instantly get ghosted for having the trait

It's better this way, because then you have to doubt whether or not the person you're talking to is an "NPC" or not IC, giving you more leeway to abuse them (killing a mindbroken person at best counts as animal abuse)

It would be even funnier if we rebased the NPCConversationSystem from Nyano, and/or make the mindbroken NPCs talk using ChatGPT2.

Just use the free Groq API and something like Llama3 on the server, I could probably help you write the code for it. It'd be funny!!

@FoxxoTrystan FoxxoTrystan added the Status: Needs Discussion Must be discussed label Nov 21, 2024
Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it false a lot of servers will not enjoy this change if they update and they dont know about it, this should be toggled true on server choices.

Content.Shared/CCVar/CCVars.cs Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Nov 30, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@bruhmogus
Copy link

20241130151052_1

mindbreaking's punishment should be changed if this is merged, as it basically kills them (and might be prevention of revival?)

@VMSolidus
Copy link
Member Author

20241130151052_1

mindbreaking's punishment should be changed if this is merged, as it basically kills them (and might be prevention of revival?)

I completely forgot this DeltaV feature even exists lmao. Yea mindbreaking people on EE is not like mindbreaking people on DeltaV. The design intention behind it is that mindbreaking someone is essentially a "Metaphysical" form of murder, and thus should be reserved only as a capital punishment, or as Self-Defense in the case of being attacked by someone with psionic powers.

@bruhmogus
Copy link

20241130151052_1
mindbreaking's punishment should be changed if this is merged, as it basically kills them (and might be prevention of revival?)

I completely forgot this DeltaV feature even exists lmao. Yea mindbreaking people on EE is not like mindbreaking people on DeltaV. The design intention behind it is that mindbreaking someone is essentially a "Metaphysical" form of murder, and thus should be reserved only as a capital punishment, or as Self-Defense in the case of being attacked by someone with psionic powers.

yeah what im saying is just "this is literal murder, and should be treated as such"

@RustedBR
Copy link

RustedBR commented Dec 3, 2024

Isn't this, for the player, the same thing as getting sacrificed as a psion?

@VMSolidus VMSolidus merged commit 80f8348 into Simple-Station:master Dec 16, 2024
11 of 12 checks passed
sleepyyapril pushed a commit to sleepyyapril/Einstein-Engines that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants