Don't Require Running in Release to Test Mood #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEATHB4DEFEAT
added
Priority: 4-Low
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
Status: Merge Conflict
|
wtf conflicts?? I made sure to be up to date with master |
SimpleStation14
changed the title
…ngines into better-mood-debug
VMSolidus
requested changes
Nov 20, 2024
Comment on lines
+2570
to
+2574
| #if RELEASE | ||
| CVarDef.Create("mood.enabled", true, CVar.SERVER); | ||
| #else | ||
| CVarDef.Create("mood.enabled", false, CVar.SERVER); | ||
| #endif |
There was a problem hiding this comment.
And now Mood doesn't work in Release configuration.
There was a problem hiding this comment.
In all instances of (!_config.GetCVar(CCVars.MoodEnabled)
FoxxoTrystan
requested review from
a team,
VMSolidus,
Pspritechologist and
FoxxoTrystan
and removed request for
a team
VMSolidus
approved these changes
Nov 30, 2024
sleepyyapril
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.